Prevent format injection in hosting Windows PAL printf functions when redirected to file #119568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
jkoritzinsky
approved these changes
Sep 12, 2025
Member
|
Thank you! |
Member
|
Does this need to be backported to .NET 10? |
Contributor
Author
|
The original issue was found as part of GitHub Actions when adding test runs for .NET 10 RC1 here, because GitHub Actions uses redirected output, and we set the DbgDump env vars for diagnostic purposes: https://github.com/MonoMod/MonoMod/actions/runs/17620993089/job/50066937459?pr=258 This seems like a silly thing to fail for GA, so I at least would like it to be. |
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17742477456 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119566