Skip to content

Conversation

ManickaP
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 07:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Windows MsQuic dependency to version 2.4.15 from the previous version 2.4.8. This is a standard dependency update to incorporate newer features, bug fixes, or security improvements from the MsQuic library.

  • Updates MsQuic Schannel version from 2.4.8 to 2.4.15

@ManickaP ManickaP requested a review from a team September 16, 2025 07:44
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 16, 2025
@ManickaP ManickaP added area-System.Net.Quic and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 16, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP
Copy link
Member Author

Running tests with expected version on Windows:

MsQuic supported and using 'msquic.dll 2.4.15.130165181 (ccc4b18d1900930aae512a453013665d03dac7fd)' (Schannel).
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
MsQuic Counters:
    CONN_CREATED 1605
    CONN_HANDSHAKE_FAIL 24
    CONN_APP_REJECT 8
    CONN_LOAD_REJECT 0

Unobserved exceptions of 0 different types: 

  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 429, Errors: 0, Failed: 0, Skipped: 1, Time: 94.948s

@ManickaP
Copy link
Member Author

/ba-g #119763

@ManickaP ManickaP merged commit b297427 into dotnet:main Sep 16, 2025
161 of 163 checks passed
@ManickaP ManickaP deleted the msquic-upd branch September 16, 2025 14:12
@ManickaP
Copy link
Member Author

/backport to release/10.0

Copy link
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17768705332

Copy link
Contributor

@ManickaP backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update Windows MsQuic
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update Windows MsQuic
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@karelz karelz added this to the 11.0.0 milestone Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants