[interp] Fix compile failures causing silent fallback to JIT #119775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseservices\invalid_operations\InvalidOperations is currently failing downstream of its actual failure - the actual failure is that the interpreter doesn't support the type of calli the test is doing, but right now when we fail compilation as a result of this we silently retry with the JIT.
It seems like the intended behavior is that if we configure a method to be interpreted and it fails due to BADCODE or NO_WAY, we want to fail-fast instead of falling back to JIT. Not sure this is the right solution though.
@janvorli Is this the kind of fix you had in mind? I didn't find a better way to do it but you might have some ideas.