[release/10.0] Use unpredicated movprfx with SVE2 fminnmp and fmaxnmp #119805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codegen is currently emitting a predicated `movprfx` with these instructions in combination with `ConditionalSelect`, which results in unpredictable behaviour. Use unpredicated `movprfx` instead and apply the mask to the result of the instruction.
…o movprfx optimization
JulieLeeMSFT
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
JulieLeeMSFT
approved these changes
Sep 22, 2025
rbhanda
added
Servicing-approved
This was referenced Sep 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119390 to release/10.0
/cc @EgorBo @snickolls-arm
Customer Impact
Codegen is currently emitting a predicated movprfx with these instructions in combination with ConditionalSelect, which results in unpredictable behaviour. This may impact customers using SVE apis, although, the feature is still experimental and is not complete.
Regression
Testing
Tests are added
Risk
Low. This is a low risk change as the SVE feature remains experimental in .Net9 and .Net10.