Centralize vararg test exclusions #119878

jkotas · 2025-09-19T04:26:15Z

No description provided.

Copilot

Pull Request Overview

This PR centralizes and consolidates vararg test exclusions across the test suite. Previously, vararg-related test exclusions were scattered throughout different platform-specific sections of the issues.targets file with inconsistent conditions and duplicate entries.

Key changes:

Consolidates all vararg test exclusions into a single section with unified conditions
Updates conditional logic to exclude tests on non-Windows platforms OR when using NativeAOT
Removes ARM-specific test project files that are no longer needed
Updates platform detection logic to allow varargs on ARM Windows platforms

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/tests/issues.targets	Consolidates scattered vararg exclusions into single section with unified conditions
src/tests/JIT/Directed/arglist/vararg_TargetUnix.csproj	Removes Unix-specific vararg test project (entire file deleted)
src/tests/JIT/Directed/arglist/vararg_TargetWindows.csproj	Updates comment from "arglist IL opcode" to "varargs"
src/tests/JIT/Directed/PREFIX//arglist_Target_ARM_.ilproj	Removes ARM-specific test project files (multiple files deleted)
src/tests/JIT/Directed/PREFIX/*/arglist_Target_BIT_.ilproj	Updates comments and removes ARM exclusion conditions
src/tests/JIT/Directed/PREFIX/*/arglistARM.il	Removes ARM-specific IL test files (multiple files deleted)
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs	Updates IsArgIteratorSupported to allow varargs on ARM Windows

src/tests/JIT/Directed/PREFIX/unaligned/1/arglist_Target_32BIT_unaligned_1.ilproj

src/tests/issues.targets

jkotas · 2025-09-19T04:35:44Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-09-19T04:35:54Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-09-19T04:36:55Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-19T04:37:06Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-21T05:38:39Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-10-21T05:38:49Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-21T05:42:02Z

@janvorli Could you please take a look?

I have replaced the piecemeal conditions to disable vararg tests with unform dynamic check. It is self-documenting and allows us to enable/disable vararg testing as needed. I think we should adopt the same style for other features that are not universally available and that number of tests depend on, like exception interop discussed in the other PR.

src/tests/JIT/Directed/PREFIX/unaligned/1/arglist.il

jkotas · 2025-10-22T07:26:56Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-10-22T07:27:12Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-22T08:18:51Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-10-22T18:50:21Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-22T19:46:02Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-10-22T19:46:11Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-23T03:51:20Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-10-23T03:51:30Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-23T05:57:43Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-10-23T05:58:00Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-23T07:34:19Z

/azp run runtime-coreclr outerloop

jkotas · 2025-10-23T07:34:30Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-10-23T07:34:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-10-23T07:34:40Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-23T07:35:49Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-10-23T07:35:59Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-23T16:25:21Z

/azp run runtime-nativeaot-outerloop

jkotas · 2025-10-23T16:25:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-10-23T16:25:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-10-23T16:25:40Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-23T20:46:41Z

/ba-g infrastructure timeouts

…host removal (#121569) Windows removed localhost support in recent updates, causing `ERROR_NETNAME_DELETED` (0x40/64) when accessing UNC paths like `\\LOCALHOST\share\path`. This triggers a `Debug.Assert` failure in `FillAttributeInfo` because the error code isn't recognized as a path unreachable condition. ### Changes - **Interop.Errors.cs**: Added `ERROR_NETNAME_DELETED = 0x40` constant - **FileSystem.Attributes.Windows.cs**: Added `ERROR_NETNAME_DELETED` to `IsPathUnreachableError` pattern match This aligns handling with other network path errors (`ERROR_BAD_NETPATH`, `ERROR_BAD_NET_NAME`, etc.) already in the unreachable path list. ### Context ```csharp if (!IsPathUnreachableError(errorCode)) { Debug.Assert(errorCode == ERROR_ACCESS_DENIED || errorCode == ERROR_SHARING_VIOLATION || errorCode == ERROR_SEM_TIMEOUT, $"Unexpected error code getting attributes {errorCode} from path {path}"); // ... } ``` Previously, `ERROR_NETNAME_DELETED` fell through to the assertion. Now it's handled as unreachable. Fixes #120380 (possibly same root cause)  <details> <summary>Original prompt</summary> ---- *This section details on the original issue you should resolve* <issue_title>System.IO.Tests fails with "Unexpected error code getting attributes 64 from path \\LOCALHOST"</issue_title> <issue_description>## Build Information Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1181840 Build error leg or test failing: System.IO.FileSystem.Tests.WorkItemExecution Pull request: #119878  ## Error Message Fill the error message using [step by step known issues guidance](https://github.com/dotnet/arcade/blob/main/Documentation/Projects/Build%20Analysis/KnownIssueJsonStepByStep.md).  ```json { "ErrorMessage": "Unexpected error code getting attributes 64 from path \\\\LOCALHOST", "ErrorPattern": "", "BuildRetry": false, "ExcludeConsoleLog": false } ```  ### Known issue validation **Build: 🔎** https://dev.azure.com/dnceng-public/public/_build/results?buildId=1181840 **Error message validated:** `[Unexpected error code getting attributes 64 from path \LOCALHOST`] **Result validation:** ❌ Known issue did not match with the provided build. **Validation performed at:** 10/22/2025 2:11:40 PM UTC   ### Known issue validation **Build: 🔎** https://dev.azure.com/dnceng-public/public/_build/results?buildId=1181840 **Error message validated:** `[Unexpected error code getting attributes 64 from path \\LOCALHOST`] **Result validation:** ✅ Known issue matched with the provided build. **Validation performed at:** 10/22/2025 2:17:17 PM UTC   ### Report |Build|Definition|Test|Pull Request| |---|---|---|---| |[1200811](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200811)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200811&view=ms.vss-test-web.build-test-results-tab&runId=33235252&resultId=172656)|| |[1200758](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200758)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200758&view=ms.vss-test-web.build-test-results-tab&runId=33234124&resultId=173264)|dotnet/runtime#121524| |[1200347](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200347)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200347&view=ms.vss-test-web.build-test-results-tab&runId=33216846&resultId=173285)|dotnet/runtime#121524| |[1200222](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200222)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200222&view=ms.vss-test-web.build-test-results-tab&runId=33212640&resultId=172656)|| |[1199457](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1199457)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1199457&view=ms.vss-test-web.build-test-results-tab&runId=33191298&resultId=172173)|| |[1199150](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1199150)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1199150&view=ms.vss-test-web.build-test-results-tab&runId=33185540&resultId=172656)|| |[1198822](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1198822)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1198822&view=ms.vss-test-web.build-test-results-tab&runId=33177786&resultId=172656)|| |[1197942](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1197942)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1197942&view=ms.vss-test-web.build-test-results-tab&runId=33151894&resultId=173290)|| |[1197801](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1197801)|dotnet/runtime|[System.IO.FileSystem.Tests.WorkItemExecution](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1197801&view=ms.vss-test-web.build-test-results-tab&runId=33149392&resultId=170860)|| |[1197409](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1197409)|dotnet/runtime|[System.IO.FileSys... </details> - Fixes #120974  --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 19, 2025 04:26

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 19, 2025

Copilot AI reviewed Sep 19, 2025

View reviewed changes

jkotas commented Sep 19, 2025

View reviewed changes

src/tests/JIT/Directed/PREFIX/unaligned/1/arglist_Target_32BIT_unaligned_1.ilproj Show resolved Hide resolved

dotnet-policy-service bot assigned jkotas Sep 19, 2025

jkotas commented Sep 19, 2025

View reviewed changes

src/tests/issues.targets Outdated Show resolved Hide resolved

This was referenced Sep 19, 2025

[android] Android.Device_Emulator.JIT.Test failing on emulators with CoreCLR #112633

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

jkotas added 2 commits October 20, 2025 18:33

Centralize vararg test exclusions

5cfa543

DIsable vararg tests using COnditionalFact

b7a556d

jkotas force-pushed the vararg-tests branch from c942bd2 to b7a556d Compare October 21, 2025 05:18

jkotas requested a review from janvorli October 21, 2025 05:38

This was referenced Oct 21, 2025

Unable to pull image from mcr.microsoft.com #117164

Open

[NativeAOT] Test_GetTotalAllocatedBytes test fails with OutOfMemoryException #119187

Closed

janvorli reviewed Oct 21, 2025

View reviewed changes

src/tests/JIT/Directed/PREFIX/unaligned/1/arglist.il Outdated Show resolved Hide resolved

janvorli approved these changes Oct 21, 2025

View reviewed changes

jkotas added 2 commits October 22, 2025 00:06

Merge branch 'main' into vararg-tests

e619da1

Simpler syntax

3a730f6

jkotas force-pushed the vararg-tests branch from 91cf1b2 to 3a730f6 Compare October 22, 2025 07:26

dotnet deleted a comment from azure-pipelines bot Oct 22, 2025

jkotas mentioned this pull request Oct 22, 2025

Disable CoreCLR tests crashing merged test suites fully interpreted #120911

Merged

Test library version in IL

e73411b

jkotas force-pushed the vararg-tests branch from b44d0ff to e73411b Compare October 23, 2025 07:34

jkotas added 2 commits October 23, 2025 09:21

More cleanup

5042c17

Merge branch 'main' into vararg-tests

716adfa

jkotas merged commit 1e09fc1 into dotnet:main Oct 23, 2025
126 of 150 checks passed

github-project-automation bot moved this to Done in Runtime Infra Oct 23, 2025

jkotas deleted the vararg-tests branch October 23, 2025 20:47

dotnet-maestro bot mentioned this pull request Oct 24, 2025

[main] Source code updates from dotnet/runtime dotnet/dotnet#3087

Merged

tomeksowi mentioned this pull request Oct 30, 2025

Call PlatformDetection checks manually in IL tests #121196

Closed

Copilot AI mentioned this pull request Nov 13, 2025

Add ERROR_NETNAME_DELETED to IsPathUnreachableError for Windows localhost removal #121569

Merged

Centralize vararg test exclusions #119878

Centralize vararg test exclusions #119878

Uh oh!

Conversation

jkotas commented Sep 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

jkotas commented Sep 19, 2025

Uh oh!

azure-pipelines bot commented Sep 19, 2025

Uh oh!

jkotas commented Sep 19, 2025

Uh oh!

azure-pipelines bot commented Sep 19, 2025

Uh oh!

jkotas commented Oct 21, 2025

Uh oh!

azure-pipelines bot commented Oct 21, 2025

Uh oh!

jkotas commented Oct 21, 2025

Uh oh!

Uh oh!

jkotas commented Oct 22, 2025

Uh oh!

azure-pipelines bot commented Oct 22, 2025

Uh oh!

jkotas commented Oct 22, 2025

Uh oh!

azure-pipelines bot commented Oct 22, 2025

Uh oh!

jkotas commented Oct 22, 2025

Uh oh!

azure-pipelines bot commented Oct 22, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

jkotas commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants