[interp] Make InterpreterStub handle being called on threads without a Thread object #119906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the InterpreterStub to handle being called on threads that don't have a managed Thread object. This is necessary for fixing the Interop\GCBridge\BridgeTest.
- Adds null check and thread setup logic in Thread::GetInterpThreadContext()
- Modifies InterpreterStub assembly to handle null thread pointers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/vm/threads.cpp | Adds null thread handling logic to GetInterpThreadContext() method |
| src/coreclr/vm/amd64/AsmHelpers.asm | Adds null check for thread pointer in InterpreterStub assembly code |
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
|
If we decide this is an OK fix I'll update the other versions of InterpreterStub. |
jkotas
reviewed
Sep 19, 2025
Update helpers for other targets
jkotas
reviewed
Sep 19, 2025
jkotas
approved these changes
Sep 19, 2025
|
Just noticed I forgot to add a contract, this new helper function should be LIMITED_METHOD_CONTRACT right? |
Add contract
jkotas
reviewed
Sep 19, 2025
jkotas
reviewed
Sep 19, 2025
jkotas
reviewed
Sep 19, 2025
xtqqczze
pushed a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Sep 20, 2025
…a Thread object (dotnet#119906) Make InterpreterStub handle being called on threads without a Thread object Fixes Interop\GCBridge\BridgeTest --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Interop\GCBridge\BridgeTest, sort of (it also has an intermittent gc hole I think is fixed by #119867)