Fix RoundTrip_Export_Import_SPKI and fix typos for SPKI #119919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PranavSenthilnathan
commented
Sep 19, 2025
PranavSenthilnathan
commented
- Change RoundTrip_Export_Import_SPKI to actually test SPKI instead of PKCS#8
- Change SubjectKeyPublicInfo to SubjectPublicKeyInfo
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the RoundTrip_Export_Import_SPKI test method to actually test SPKI (Subject Public Key Info) format instead of incorrectly testing PKCS#8 private key format, and corrects spelling from "SubjectKeyPublicInfo" to the proper "SubjectPublicKeyInfo" throughout the codebase.
- Fix the
RoundTrip_Export_Import_SPKItest to use SPKI export/import methods instead of PKCS#8 private key methods - Rename helper methods and delegates from
SubjectKeyPublicInfotoSubjectPublicKeyInfofor correct terminology - Update test assertions to verify that private key export throws an exception when importing only public key material
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SlhDsaTestHelpers.cs | Rename helper methods and delegates from SubjectKeyPublicInfo to SubjectPublicKeyInfo |
| SlhDsaImplementationTests.cs | Fix RoundTrip_Export_Import_SPKI test logic and update method calls |
| SlhDsaFactoryTests.cs | Update method calls and test names to use correct SubjectPublicKeyInfo naming |
| MLDsaTestHelpers.cs | Rename helper methods and delegates from SubjectKeyPublicInfo to SubjectPublicKeyInfo |
| MLDsaImplementationTests.cs | Update method calls and test names to use correct SubjectPublicKeyInfo naming |
| CompositeMLDsaTestHelpers.cs | Rename helper methods and delegates from SubjectKeyPublicInfo to SubjectPublicKeyInfo |
| CompositeMLDsaImplementationTests.cs | Fix RoundTrip_Export_Import_SPKI test logic and update method calls |
| CompositeMLDsaFactoryTests.cs | Update method calls and test names to use correct SubjectPublicKeyInfo naming |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
2 tasks
vcsjones
approved these changes
Sep 20, 2025
bartonjs
approved these changes
Sep 22, 2025
Member
Author
|
/backport release/10.0 |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18015555383 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.