-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add compression magic number detection to System.Formats.Tar with helpful error messages #119996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
iremyux
wants to merge
35
commits into
dotnet:main
Choose a base branch
from
iremyux:89056-tar-magic-numbers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−3
Draft
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b8a5ece
Add compression detection for TAR files with helpful error messages
iremyux 2135e0e
Merge branch 'main' into 89056-tar-magic-numbers
iremyux ed092f0
Fox comment
iremyux 3ff4e89
Merge branch '89056-tar-magic-numbers' of https://github.com/iremyux/…
iremyux 904da9d
Check the buffer lenght in local functions
iremyux ba0501f
Change checks to switch-case
iremyux 4837fe8
Change where we check the magic numbers + do not differentiate betwee…
iremyux 56bfc98
Merge branch 'dotnet:main' into 89056-tar-magic-numbers
iremyux 4703aa2
Remove the check from TryGetNextHeaderAsync method
iremyux ac4aa8b
Merge branch 'main' into 89056-tar-magic-numbers
iremyux 9b4a528
Change the function's name and remove unreachable throw
iremyux 56b541e
Merge branch '89056-tar-magic-numbers' of https://github.com/iremyux/…
iremyux 26bf6b4
Fix build error
iremyux 28a536e
Use string resources
iremyux c7b0380
Add compression detection for TAR files with helpful error messages
iremyux eeaa2cd
Fox comment
iremyux dd33737
Check the buffer lenght in local functions
iremyux 614de69
Change checks to switch-case
iremyux 26ffa48
Change where we check the magic numbers + do not differentiate betwee…
iremyux a62bca0
Remove the check from TryGetNextHeaderAsync method
iremyux 5d1de04
Change the function's name and remove unreachable throw
iremyux 2672306
Fix build error
iremyux c973705
Use string resources
iremyux 6a70987
Merge branch '89056-tar-magic-numbers' of https://github.com/iremyux/…
iremyux e1ca749
Add compression detection for TAR files with helpful error messages
iremyux 07f5478
Change where we check the magic numbers + do not differentiate betwee…
iremyux f3eb72c
Remove the check from TryGetNextHeaderAsync method
iremyux 987e5b2
Merge branch '89056-tar-magic-numbers' of https://github.com/iremyux/…
iremyux 25618b0
Change the test assert since we changed the error message
iremyux e342175
Change the function name + only throw inside the function if we can m…
iremyux 73af2b9
Merge branch 'main' into 89056-tar-magic-numbers
iremyux 87ad6f2
Trailing whitespaces
iremyux 08bb9e8
Wrap documentation comment in <summary> tag
iremyux dfd5ceb
Remove TarInvalidArchiveFormat from strings
iremyux 9527212
Update src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHea…
iremyux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.