[clr-interp] InterpreterJitManager::ResolveEHClause behaved incorrectly #120009
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We need to use IsCanonicalSubtype, not IsSharedByGenericInstantiations as IsSharedByGenericInstantiations returns false for System.__Canon. - This caused an issue where shared generic catch did not work correctly for methods which simply attempted to catch T, not a more complex generic type.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the interpreter's exception handling clause resolution by correcting the method used to determine when to cache type handles. The change replaces IsSharedByGenericInstantiations() with IsCanonicalSubtype() to properly handle shared generic catch clauses.
- Fixed incorrect method call that was causing shared generic catch blocks to fail
- Corrected logic for determining when exception handler type handles should be cached
github-actions
bot
added
the
needs-area-label
69 tasks
jkotas
approved these changes
Sep 23, 2025
jkotas
added
area-CodeGen-Interpreter-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
janvorli
approved these changes
Sep 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test Regressions\coreclr\GitHub_66005\test66005 under the interpreter