Fix ResourceUpdater.Dispose() #120029
Merged
Fix ResourceUpdater.Dispose() #120029
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
|
Tagging subscribers to this area: @vitek-karas, @agocke |
jtschuster
removed
the
needs-area-label
agocke
reviewed
Sep 24, 2025
agocke
added a commit
to agocke/runtime
that referenced
this pull request
Sep 26, 2025
After dotnet#120029, some of the code was unreachable. This change removes that code and standardizes the field style to the .NET Code Style guidelines.
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18027400694 |
4 tasks
agocke
added a commit
that referenced
this pull request
Sep 26, 2025
After #120029, some of the code was unreachable. This change removes that code and standardizes the field style to the .NET Code Style guidelines.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apphost ResourceUpdater doesn't dispose of the PEReader when
leaveOpenis true, but theleaveOpenshould only apply to the FileStream passed to the constructor. The PEReader is not accessible from the creator and cannot be disposed of elsewhere. This causes some race conditions, especially in cases where the PEReader ends up mapping the file into memory.Fixes dotnet/sdk#50784