[interp] Fix boundary condition where a leave is not added to the leaves table #120228
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the leave target is the exact end of the try block
There was a problem hiding this comment.
Pull Request Overview
Fixes a boundary condition bug in the CoreCLR interpreter where a leave instruction is not properly added to the leaves table when the leave target is at the exact end of a try region.
- Changes the boundary check from
<=to<to exclude the exact end position of try regions - Ensures proper finally call island block creation for leave instructions at try region boundaries
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
|
Jan noticed another wrong comparison that I will fix once the test passes locally. |
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Interop\PInvoke\CriticalHandles\Test\Test