-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Remove an STJ deep nested object test causing occasional failures #120247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove an STJ deep nested object test causing occasional failures #120247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Removes a problematic deep nested object test that was causing intermittent stack overflow failures on test machines. The test with depth factor 16 was pushing the limits of test machine configurations without providing additional value beyond existing test scenarios.
Key Changes:
- Removed the most aggressive nested depth test case (depth factor 16)
- Updated comment to explain memory constraint reasoning
- Retained other depth test cases that provide adequate coverage
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
/backport to release/10.0 |
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18138317132 |
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18138382839 |
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18138388933 |
We've seen some occurrences of this particular test causing stack overflows on test machines. The test was pushing the limits of previous test machine configurations, but it wasn't adding any material value beyond the other test scenarios.
Once merged, this change will be backported to all servicing branches to eliminate the test failure noise.