Skip to content

Conversation

jeffhandley
Copy link
Member

We've seen some occurrences of this particular test causing stack overflows on test machines. The test was pushing the limits of previous test machine configurations, but it wasn't adding any material value beyond the other test scenarios.

Once merged, this change will be backported to all servicing branches to eliminate the test failure noise.

@jeffhandley jeffhandley self-assigned this Sep 30, 2025
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 07:34
@jeffhandley jeffhandley added area-System.Text.Json test-enhancement Improvements of test source code labels Sep 30, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes a problematic deep nested object test that was causing intermittent stack overflow failures on test machines. The test with depth factor 16 was pushing the limits of test machine configurations without providing additional value beyond existing test scenarios.

Key Changes:

  • Removed the most aggressive nested depth test case (depth factor 16)
  • Updated comment to explain memory constraint reasoning
  • Retained other depth test cases that provide adequate coverage

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@jeffhandley jeffhandley merged commit cf42117 into dotnet:main Sep 30, 2025
91 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/remove-stj-depth16-test branch September 30, 2025 17:29
@jeffhandley
Copy link
Member Author

/backport to release/10.0
/backport to release/9.0-staging
/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18138317132

@jeffhandley
Copy link
Member Author

/backport to release/9.0-staging

Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18138382839

@jeffhandley
Copy link
Member Author

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18138388933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Text.Json test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants