[DRAFT] Interp mode testing #120281

davidwrighton · 2025-09-30T23:57:31Z

Adjust interpmode to automatically work in a few more ways, so that we can run a larger test run with InterpMode=3

…odeTesting

- We automatically detected that intrinsics should throw PNSE, but we didn't correctly handle the IL stack in those cases

- StackMark handling relies on comparing the stackmark's address to the stack pointer, but the interpreter stack is seperate. - Fix this by converting the StackMark pointer to a pointer on the OS stack and then do the compares

- Open virtual delegates have an entrypoint which cannot be processed by NonVirtualEntry2MethodDesc. Handle them specially.

davidwrighton · 2025-09-30T23:57:48Z

/azp run runtime-interpreter

azure-pipelines · 2025-09-30T23:58:01Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2025-09-30T23:58:25Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copilot

Pull Request Overview

This PR adjusts the interpreter mode testing to enable more comprehensive testing with InterpMode=3. The changes modernize the interpreter configuration system and add better support for interpreter compatibility with various system features.

Key changes include:

Switching from assembly-specific interpreter configuration to a global InterpMode=3 setting
Adding interpreter stack mark conversion functionality for proper stack walking
Implementing compatibility adjustments between interpreter mode and hardware intrinsics/ReadyToRun

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/tests/Common/CLRTest.Execute.Batch.targets	Replaces assembly-specific interpreter config with global InterpMode=3
src/tests/Common/CLRTest.Execute.Bash.targets	Replaces assembly-specific interpreter config with global InterpMode=3
src/coreclr/vm/stackwalk.h	Adds function declaration for stack mark conversion
src/coreclr/vm/stackwalk.cpp	Implements stack mark conversion for interpreter frames
src/coreclr/vm/reflectioninvocation.cpp	Updates SkipStruct to handle interpreter stack marks properly
src/coreclr/vm/jitinterface.cpp	Simplifies interpreter loading logic
src/coreclr/vm/jithost.cpp	Adds EnableHWIntrinsic configuration support
src/coreclr/vm/interpexec.cpp	Improves delegate invocation handling for open virtual dispatch
src/coreclr/vm/eeconfig.h	Adds interpreter and hardware intrinsic configuration fields
src/coreclr/vm/eeconfig.cpp	Implements interpreter mode configuration logic
src/coreclr/vm/codeman.cpp	Adds interpreter mode compatibility with hardware features
src/coreclr/vm/appdomain.cpp	Updates CallersDataWithStackMark for interpreter compatibility
src/coreclr/interpreter/eeinterp.cpp	Updates interpreter mode documentation comments
src/coreclr/interpreter/compiler.cpp	Fixes PlatformNotSupportedException intrinsic handling

Copilot · 2025-09-30T23:58:24Z

src/coreclr/vm/stackwalk.cpp

+
+            pFrame = pFrame->PtrNextFrame();
+        }
+


The assertion message should be more descriptive and include context about what stackMark value was being processed to aid debugging.

Suggested change

LOG((LF_ALWAYS, LL_ALWAYS, "Unable to find InterpMethodContextFrame for stackMark=%p (stackLimit=%p, stackBase=%p)\n", stackMark, pThread->GetCachedStackLimit(), pThread->GetCachedStackBase()));

Copilot · 2025-09-30T23:58:24Z

src/coreclr/vm/reflectioninvocation.cpp

+    SkipStruct(StackCrawlMark* mark, PTR_Thread thread) :
+        pStackMark(mark)
+#ifdef FEATURE_INTERPRETER
+        // Since the interpreter has its own stack, we need to get a pointer which can be compared on the real
+        // stack so that IsInCalleesFrames can work correctly.
+        , stackMarkOnOSStack(ConvertStackMarkToPointerOnOSStack(thread, mark))
+#endif
+    {
+    }


[nitpick] The constructor initializer list formatting is inconsistent. The comma should be aligned with other initializers, not placed at the beginning of line 701.

Copilot · 2025-09-30T23:58:25Z

src/coreclr/vm/eeconfig.cpp

+    enableHWIntrinsic = CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_EnableHWIntrinsic);
+    if (CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_InterpMode) >= 3)
+    {
+        // R2R mode 3 disables all hw intrinsics


The comment mentions 'R2R mode 3' but should refer to 'InterpMode 3' for clarity, as this is about interpreter mode, not ReadyToRun mode.

Suggested change

// R2R mode 3 disables all hw intrinsics

// InterpMode 3 disables all hw intrinsics

Copilot · 2025-09-30T23:58:25Z

src/coreclr/vm/interpexec.cpp


-                    DELEGATEREF delegateObj = LOCAL_VAR(callArgsOffset, DELEGATEREF);
+                    DELEGATEREF* delegateObj = LOCAL_VAR_ADDR(callArgsOffset, DELEGATEREF);
                    NULL_CHECK(delegateObj);


NULL_CHECK is being called on a pointer to DELEGATEREF rather than the DELEGATEREF itself. This should be NULL_CHECK(*delegateObj) or the logic should be restructured to check the actual delegate reference.

Suggested change

NULL_CHECK(delegateObj);

NULL_CHECK(*delegateObj);

davidwrighton · 2025-09-30T23:59:03Z

/azp run runtime-interpreter

azure-pipelines · 2025-09-30T23:59:12Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2025-10-01T00:26:12Z

src/coreclr/vm/codeman.cpp

+    bool allowHWIntrinsic = true;
+
+#if defined(FEATURE_INTERPRETER)
+    if (maxVectorTBitWidth != 128 && CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_InterpMode) >= 2)


Can this be GetConfigValue(CLRConfig::EXTERNAL_InterpMode) == 3?

davidwrighton added 7 commits September 30, 2025 12:02

InterpMode testing

2f4bb38

Merge branch 'main' of https://github.com/dotnet/runtime into InterpM…

306ab14

…odeTesting

[clr-interp] Fix behavior of PNSE for intrinsics

7f288de

- We automatically detected that intrinsics should throw PNSE, but we didn't correctly handle the IL stack in those cases

[clr-interp] StackMark handling for interpreter

6abc310

- StackMark handling relies on comparing the stackmark's address to the stack pointer, but the interpreter stack is seperate. - Fix this by converting the StackMark pointer to a pointer on the OS stack and then do the compares

[clr-interp] Fix Open Virtual Delegates

08bc393

- Open virtual delegates have an entrypoint which cannot be processed by NonVirtualEntry2MethodDesc. Handle them specially.

Copilot review feedback for stack mark PR

dab6208

InterpMode=3 change for Bash targets

36ebb2c

Copilot AI review requested due to automatic review settings September 30, 2025 23:57

davidwrighton requested review from BrzVlad, janvorli and kg as code owners September 30, 2025 23:57

github-actions bot added the area-VM-coreclr label Sep 30, 2025

davidwrighton marked this pull request as draft September 30, 2025 23:57

dotnet-policy-service bot assigned davidwrighton Sep 30, 2025

Copilot AI reviewed Sep 30, 2025

View reviewed changes

jkotas reviewed Oct 1, 2025

View reviewed changes

This was referenced Oct 1, 2025

Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922

Open

Unable to pull image from mcr.microsoft.com #117164

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DRAFT] Interp mode testing #120281

[DRAFT] Interp mode testing #120281

davidwrighton commented Sep 30, 2025

Uh oh!

davidwrighton commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

dotnet-policy-service bot commented Sep 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

davidwrighton commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

jkotas Oct 1, 2025

Uh oh!

Uh oh!



	LOG((LF_ALWAYS, LL_ALWAYS, "Unable to find InterpMethodContextFrame for stackMark=%p (stackLimit=%p, stackBase=%p)\n", stackMark, pThread->GetCachedStackLimit(), pThread->GetCachedStackBase()));

	// R2R mode 3 disables all hw intrinsics
	// InterpMode 3 disables all hw intrinsics

[DRAFT] Interp mode testing #120281

Are you sure you want to change the base?

[DRAFT] Interp mode testing #120281

Conversation

davidwrighton commented Sep 30, 2025

Uh oh!

davidwrighton commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

dotnet-policy-service bot commented Sep 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

davidwrighton commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

jkotas Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!