[clr-interp] Fix interpreter safepoint to just do a GC transition and not call the managed JIT_GCPoll helper #120302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not call the managed JIT_GCPoll helper
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an infinite recursion issue in the CoreCLR interpreter's safepoint implementation. The problem occurs when using a pure interpreted environment where calling the managed JIT_GCPoll helper from INTOP_SAFEPOINT creates recursion since JIT_GCPoll itself is managed code.
Key changes:
- Replaces the managed
JIT_GCPoll()call with a direct GC transition usingGCX_PREEMP() - Adds explanatory comment about the purpose of the GC transition
github-actions
bot
added
the
needs-area-label
jkotas
approved these changes
Oct 1, 2025
jkotas
added
area-CodeGen-Interpreter-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The managed helper includes the GC poll within it, since JIT_GCPoll is itself managed, when we are in a pure interpreted environment, we will go into infinite recursion triggering the INTOP_SAFEPOINT code