-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add missing overloads to flow rune proposal #120314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tarekgh
merged 25 commits into
dotnet:main
from
Joy-less:add-missing-overloads-to-flow-rune-proposal
Oct 15, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0f5ba8a
Add missing overloads
Joy-less 6e63506
Add refs to added missing overloads
Joy-less 77fa228
Fix IndexOf/LastIndexOf char OrdinalIgnoreCase
Joy-less 444d4b8
Add tests & fixes
Joy-less 20b8733
Fix Copilot suggestions
Joy-less 8166e82
Rename `right` to `other`
Joy-less 45fd035
Make `LastIndexOf` public
Joy-less 6853c73
Add commented-out test
Joy-less 0812e82
Rename `right` to `other` in refs
Joy-less f2e0027
Add doc comments to IndexOf char
Joy-less b7956ac
Update docs from `-1` to `a negative value (e.g. -1)`
Joy-less 832a748
Refactor duplicate return statements
Joy-less 347d59c
Add foreign cases to char Equals StringComparison test
Joy-less 97dba93
Add foreign/empty cases to IndexOf char/Rune
Joy-less 4d126f4
Fix length bounds
Joy-less 2d255b5
Add convert to string test case
Joy-less 48cecde
Fix \0 edge case?
Joy-less d31505c
Add more convert to string test cases
Joy-less d2dbd8f
Remove most likely incorrect fix
Joy-less 54c2f80
Add `Length == 0` check to last index of methods
Joy-less 8abd5d3
Merge branch 'main' into add-missing-overloads-to-flow-rune-proposal
tarekgh 7447cee
Simplify `AsSpan` calls
Joy-less 8afe6a6
Fix invalid test arguments
Joy-less 4aa3a29
Add `IsNotAndroid` checks for Turkish "i" tests
Joy-less b97b5c1
Also add `IsNotAndroid` checks for `char` `EqualsTest`
Joy-less File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.