- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.2k
[wasm][coreCLR] unify -fwasm-exceptions and -msimd128, gcinfo #120365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Tagging subscribers to this area: @hoyosjs | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR unifies the compiler and linker flags for WebAssembly builds by consistently adding both -fwasm-exceptions and -msimd128 flags across all CoreCLR WebAssembly build configurations.
- Adds -msimd128flag alongside existing-fwasm-exceptionsflag for WASM builds
- Updates multiple CMakeLists.txt files to ensure consistent SIMD support across CoreCLR components
- Removes an obsolete TODO comment about JavaScript source maps
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description | 
|---|---|
| src/native/corehost/browserhost/sample/CMakeLists.txt | Removes obsolete TODO comment about JS source maps | 
| src/coreclr/pal/CMakeLists.txt | Adds -msimd128to both compile and link options for browser targets | 
| src/coreclr/hosts/corewasmrun/CMakeLists.txt | Adds -msimd128to compile and link options for corewasmrun | 
| src/coreclr/hosts/corerun/CMakeLists.txt | Adds -msimd128to compile and link options for browser builds | 
| src/coreclr/CMakeLists.txt | Adds -msimd128to global compile and link options for WASM architecture | 
| Why are the compile and link options needed? | 
| 
 it enables post-MVP features of the wasm spec, that were not a default for LLVM/emcc 2 years ago, when we last time updated the toolchain. There are more flags that i'm exploring here for Mono, but I didn't win yet #120423 does that answer the question ? | 
Uh oh!
There was an error while loading. Please reload this page.