Skip to content

[browser] Expect fingerprint on assemblies promoted from build #120442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2025
Merged

[browser] Expect fingerprint on assemblies promoted from build #120442

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db9ca4f
Expect fingerprint in assemblies promoted from build
maraf Oct 6, 2025
e829e7c
Expect fingerprint in assemblies promoted from build
maraf Oct 7, 2025
e53d394
Fix satellite assemblies
maraf Oct 7, 2025
a8b615f
Feedback
maraf Oct 8, 2025
09f67dd
Merge branch 'main' into maraf/WasmPublishAssemblyFingeprintIdentity
maraf Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,16 @@ private void ProcessSymbolAssets(
}
}

private string GetItemSpecWithoutFingerprint(ITaskItem asset)
=> FingerprintAssets ? asset.GetMetadata("OriginalItemSpec") : asset.ItemSpec;

private static string GetNonFingerprintedAssetItemSpec(ITaskItem asset)
{
var fileName = Path.GetFileName(asset.GetMetadata("OriginalItemSpec"));
var assetToUpdateItemSpec = Path.Combine(Path.GetDirectoryName(asset.ItemSpec), fileName);
return assetToUpdateItemSpec;
}

private void ComputeUpdatedAssemblies(
IDictionary<(string, string assemblyName), ITaskItem> satelliteAssemblies,
List<ITaskItem> filesToRemove,
Expand All @@ -440,14 +450,15 @@ private void ComputeUpdatedAssemblies(
foreach (var kvp in assemblyAssets)
{
var asset = kvp.Value;
var fileName = Path.GetFileName(asset.ItemSpec);
var fileName = Path.GetFileName(GetItemSpecWithoutFingerprint(asset));
var assetToUpdateItemSpec = FingerprintAssets ? GetNonFingerprintedAssetItemSpec(asset) : asset.ItemSpec;
if (IsWebCilEnabled)
fileName = Path.ChangeExtension(fileName, ".dll");

if (resolvedAssembliesToPublish.TryGetValue(fileName, out var existing))
{
// We found the assembly, so it'll have to be updated.
assetsToUpdate.Add(asset.ItemSpec, asset);
assetsToUpdate.Add(assetToUpdateItemSpec, asset);
filesToRemove.Add(existing);
if (!string.Equals(asset.ItemSpec, existing.GetMetadata("FullPath"), StringComparison.Ordinal))
{
Expand All @@ -465,11 +476,12 @@ private void ComputeUpdatedAssemblies(
{
var satelliteAssembly = kvp.Value;
var relatedAsset = satelliteAssembly.GetMetadata("RelatedAsset");

if (assetsToUpdate.ContainsKey(relatedAsset))
{
assetsToUpdate.Add(satelliteAssembly.ItemSpec, satelliteAssembly);
var culture = satelliteAssembly.GetMetadata("AssetTraitValue");
var fileName = Path.GetFileName(satelliteAssembly.ItemSpec);
var fileName = Path.GetFileName(GetItemSpecWithoutFingerprint(satelliteAssembly));
if (IsWebCilEnabled)
fileName = Path.ChangeExtension(fileName, ".dll");

Expand Down Expand Up @@ -517,7 +529,8 @@ private void ComputeUpdatedAssemblies(
ApplyPublishProperties(newAsemblyAsset);

newAssets.Add(newAsemblyAsset);
updatedAssetsMap.Add(asset.ItemSpec, newAsemblyAsset);
var assetToUpdateItemSpec = FingerprintAssets ? GetNonFingerprintedAssetItemSpec(asset) : asset.ItemSpec;
updatedAssetsMap.Add(assetToUpdateItemSpec, newAsemblyAsset);
break;
default:
// Satellite assembliess and compressed assets
Expand Down
Loading