Remove corewasmrun
#120541
Merged
Remove corewasmrun
#120541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update corerun to operate like corewasmrun when manually setting `CORERUN_IN_BROWSER` to `1` in src\coreclr\hosts\corerun\CMakeLists.txt. This allows corerun to operate in the same mode as corewasmrun.
AaronRobinsonMSFT
added
test-enhancement
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR removes the separate corewasmrun project and consolidates its functionality into the main corerun host. Users can now configure corerun to operate in browser mode by setting CORERUN_IN_BROWSER to 1 in the CMakeLists.txt file.
- Removes the entire
corewasmrunproject including its source files, build configuration, and documentation references - Updates
corerunto conditionally support browser execution mode whenCORERUN_IN_BROWSERis enabled - Refactors WASM-specific functionality and file handling to be configurable within the unified
corerunhost
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/hosts/corewasmrun/libCorewasmrun.pre.js | Removes JavaScript prerun configuration for the old corewasmrun |
| src/coreclr/hosts/corewasmrun/corewasmrun.cpp | Removes the standalone C++ implementation for corewasmrun |
| src/coreclr/hosts/corewasmrun/CMakeLists.txt | Removes the CMake build configuration for the corewasmrun project |
| src/coreclr/hosts/corerun/wasm/pinvoke_override.hpp | Refactors header guard names and function naming for better organization |
| src/coreclr/hosts/corerun/wasm/pinvoke_override.cpp | Updates function names and visibility for integration with corerun |
| src/coreclr/hosts/corerun/wasm/libCorerun.pre.js | Enhances JavaScript prerun logic to be more flexible with Module.preRun handling |
| src/coreclr/hosts/corerun/wasm/corerun.html | Updates HTML template with new branding and configuration for corerun-wasm |
| src/coreclr/hosts/corerun/corerun.cpp | Integrates WASM functionality and updates environment variable handling |
| src/coreclr/hosts/corerun/CMakeLists.txt | Adds conditional browser support configuration and reorganizes WASM build logic |
| src/coreclr/hosts/CMakeLists.txt | Removes reference to the corewasmrun subdirectory |
| docs/workflow/building/coreclr/wasm.md | Updates documentation to reflect the new unified corerun approach |
AaronRobinsonMSFT
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This was referenced Oct 8, 2025
Open
pavelsavara
reviewed
Oct 9, 2025
pavelsavara
reviewed
Oct 9, 2025
pavelsavara
reviewed
Oct 9, 2025
pavelsavara
approved these changes
Oct 9, 2025
radekdoulik
approved these changes
Oct 9, 2025
|
/ba-g Unrelated timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
corerunto operate likecorewasmrunwhenmanually setting
CORERUN_IN_BROWSERto1insrc\coreclr\hosts\corerun\CMakeLists.txt.This allows
corerunto operate in the same mode ascorewasmrun.