-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Split NativeAOT tests to use separate merged runners #120949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rs" to keep them running on mobile platforms after the runner consolidation
… consolidated the implementation with CoreCLR
… the nativeaot test tree
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
/azp run runtime-ioslike-coreclr |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
AppleAppBuilder throws an exception when MainLibraryFileName is set. The app should not define an executable because the entry point is the linked main. Try unsetting this value either in the targets or in AppleAppBuilder.cs. |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| <ItemGroup> | ||
| <!-- Exclude WASM support files. They can interfere with our discovery process and create extra work items that don't work. --> | ||
| <_MergedWrapperMarker Include="$(TestBinDir)**\*.MergedTestAssembly" Exclude="$(TestBinDir)**\supportFiles\*.MergedTestAssembly" /> | ||
| <_MergedWrapperMarker Include="$(TestBinDir)**\*.MergedTestAssemblyForStress" Exclude="$(TestBinDir)**\supportFiles\*.MergedTestAssemblyForStress" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkoritzinsky Do you know why the NAOT tests are using MergedTestAssemblyForStress instead of MergedTestAssembly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why they're using the stress mode. However, including the marker files here is correct.
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Set up the nativeaot tests to run as their own "merged runners" to keep them running on mobile platforms after the runner consolidation
Also remove the ComWrappers nativeaot test as it is duplicate coverage and is no longer interesting (as the NativeAOT and CoreCLR ComWrappers implementations are shared now).
This should get us to the point where we can use the merged test runners everywhere.