Remove unused PulseAllHelper method

[Copilot]

The PulseAllHelper method in src/coreclr/vm/comsynchronizable.cpp is an unused leftover from legacy Monitor implementation code. It performed monitor operations on exposed thread objects but is no longer invoked in any documented or required code path.

Changes

• Removed PulseAllHelper static function (26 lines)
• Removed call from KickOffThread after thread completion
• Removed call from ThreadNative_Start on thread startup failure

Related to #118371 which modernizes Monitor implementation.

Original prompt

Delete the unused PulseAllHelper method from the codebase. The method is defined in src/coreclr/vm/comsynchronizable.cpp and is not referenced or required for any documented or public behavior. It appears to be an old, leftover helper and its removal will help clean up the code. Ensure that all related declarations are also removed if present (such as in a header file). No functional changes should occur as a result of this deletion. The removal has been confirmed as safe from code search and context.

Context for this request includes PR #118371 (#118371) which is modernizing Monitor's implementation and cleaning up related unused helpers.

This pull request was created as a result of the following prompt from Copilot chat.

Delete the unused PulseAllHelper method from the codebase. The method is defined in src/coreclr/vm/comsynchronizable.cpp and is not referenced or required for any documented or public behavior. It appears to be an old, leftover helper and its removal will help clean up the code. Ensure that all related declarations are also removed if present (such as in a header file). No functional changes should occur as a result of this deletion. The removal has been confirmed as safe from code search and context.

Context for this request includes PR #118371 (#118371) which is modernizing Monitor's implementation and cleaning up related unused helpers.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull Request Overview

This PR removes the unused PulseAllHelper static method from the CoreCLR VM, cleaning up legacy Monitor implementation code. The method performed monitor operations on exposed thread objects but is no longer invoked anywhere in the codebase.

Key changes:

• Deleted the 26-line PulseAllHelper function definition
• Removed two call sites: one after thread completion in KickOffThread and one on startup failure in ThreadNative_Start

[dotnet-policy-service]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

[jkotas]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

/ba-g infrastructure timeouts