Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 1, 2025

Adds clarification from dotnet/dotnet-api-docs#12000 (comment) about the two documentation workflows based on the UseCompilerGeneratedDocXmlFile property.

Key points:

  • Assemblies with <UseCompilerGeneratedDocXmlFile>false</UseCompilerGeneratedDocXmlFile> (older assemblies, System.Private.CoreLib): dotnet-api-docs is source of truth; triple-slash comments sync once for new APIs only
  • Assemblies without this property (newer assemblies): source comments are source of truth; synced continuously to dotnet-api-docs

Changes:

  • adding-api-guidelines.md: Added "Documentation Workflow" subsection explaining both workflows with cross-reference to project-guidelines.md
  • project-guidelines.md: Enhanced "XML Documentation Files" section with workflow implications and cross-reference to adding-api-guidelines.md

Both documents now consistently explain when and where to update documentation based on the assembly's configuration.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/dotnet/dotnet-api-docs/issues/comments/3476392274
    • Triggering command: curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Please create PR that adds addtional information from dotnet/dotnet-api-docs#12000 (comment) to adding-api-guidelines.md doc in this repo.

Also, reconsile it with the relevant section in project-guidelines.md


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add additional information to adding-api-guidelines.md Clarify documentation workflows for assemblies with UseCompilerGeneratedDocXmlFile Nov 1, 2025
Copilot finished work on behalf of jkotas November 1, 2025 20:21
Copilot AI requested a review from jkotas November 1, 2025 20:21
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
@jkotas jkotas force-pushed the copilot/add-info-to-adding-api-guidelines branch from 84c2fd0 to 3091206 Compare November 1, 2025 20:47
@jkotas jkotas requested review from ericstj and noahfalk November 1, 2025 20:49
@jkotas
Copy link
Member

jkotas commented Nov 1, 2025

@ericstj Could you please review this - is this accurate description of the current process?

@jkotas jkotas marked this pull request as ready for review November 1, 2025 20:50
Copilot AI review requested due to automatic review settings November 1, 2025 20:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation workflow guidelines to provide clearer guidance on how API documentation is handled for different types of libraries. The key change is differentiating between libraries that use compiler-generated documentation (newer libraries) and those that rely on manually curated documentation in the dotnet-api-docs repository (older libraries).

Key changes:

  • Restructured the documentation workflow section to explain two distinct paths based on the UseCompilerGeneratedDocXmlFile property
  • Added explicit guidance on when triple-slash comments sync to dotnet-api-docs and when they serve as source of truth
  • Updated cross-references between project guidelines and API guidelines documents

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/coding-guidelines/project-guidelines.md Replaced explanation of UseCompilerGeneratedDocXmlFile=false with a reference to the expanded documentation workflow section
docs/coding-guidelines/adding-api-guidelines.md Expanded documentation section to distinguish between two workflows: compiler-generated docs (default) and manually curated docs, with clear guidance for each

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

jkotas and others added 2 commits November 1, 2025 14:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, thanks

@stephentoub
Copy link
Member

/ba-g markdown only

@jkotas
Copy link
Member

jkotas commented Nov 3, 2025

@ericstj I have tried to incorporate your suggestions. PTLA

@ericstj ericstj requested a review from gewarren November 3, 2025 22:03
@jkotas
Copy link
Member

jkotas commented Nov 3, 2025

/ba-g doc only change

@jkotas jkotas merged commit 530d14f into main Nov 3, 2025
15 of 16 checks passed
@jkotas jkotas deleted the copilot/add-info-to-adding-api-guidelines branch November 3, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants