Optimise AdvSimd GetIndexOfFirstNonAsciiByte #121382
Open
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main loop body was calling
GetIndexOfFirstNonAsciiByteInLane_AdvSimdto calculate the index of the non-ASCII character within the vector on every iteration, but the index is only needed when we have found a non-ASCII character. Instead, we can useVectorContainsNonAsciiCharfor the checks in the loop, which is much cheaper.Performance results
A simple benchmark is created to directly measure
GetIndexOfFirstNonAsciiByte, with different buffer sizes and positions of the first non-ASCII character.Run on Neoverse-V2 (lower is better)
cc @dotnet/arm64-contrib @SwapnilGaikwad