Adjust OFFSETOF__Thread__m_pInterpThreadContext for Apple mobile simulators
#121442
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlarmilos
requested review from
akoeplinger,
Copilot and
janvorli
and removed request for
Copilot
github-actions
bot
added
the
needs-area-label
kotlarmilos
added
os-ios
kotlarmilos
changed the title
OFFSETOF__Thread__m_pInterpThreadContext for Apple mobile simulators
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
This was referenced Nov 7, 2025
Open
jkoritzinsky
approved these changes
Nov 8, 2025
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes builds for Apple mobile simulators by adjusting the OFFSETOF__Thread__m_pInterpThreadContext constant to account for different structure sizes between DEBUG and RELEASE builds on Unix platforms (which includes Apple mobile simulators running on AMD64 architecture).
- Adds conditional compilation logic to differentiate DEBUG (0xb08) and RELEASE (0x2a0) offset values for Unix builds
- Aligns AMD64 implementation with the existing ARM64 pattern for the same constant
Comment on lines
+574
to
+576
| #else | ||
| #define OFFSETOF__Thread__m_pInterpThreadContext 0x2a0 | ||
| #endif |
There was a problem hiding this comment.
[nitpick] The #else and #endif directives should include comment markers for clarity, similar to how it's done in the ARM64 version of this file (see src/coreclr/vm/arm64/asmconstants.h lines 310-312).
Suggested change:
#ifdef _DEBUG
#define OFFSETOF__Thread__m_pInterpThreadContext 0xb08
#else // _DEBUG
#define OFFSETOF__Thread__m_pInterpThreadContext 0x2a0
#endif // _DEBUG
Suggested change
| #else | |
| #define OFFSETOF__Thread__m_pInterpThreadContext 0x2a0 | |
| #endif | |
| #else // _DEBUG | |
| #define OFFSETOF__Thread__m_pInterpThreadContext 0x2a0 | |
| #endif // _DEBUG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes builds for Apple mobile simulators.