Fix ildasm output on Linux by replacing I64 format specifiers with PRIx64 by Copilot · Pull Request #121687 · dotnet/runtime

Copilot · 2025-11-16T20:41:15Z

Fix incorrect ildasm output due to invalid printf format strings on Linux

Replaces Microsoft-specific I64 format specifiers with standard C99 PRI macros in ildasm and metainfo tools to fix broken output on Linux where glibc doesn't recognize the non-standard I64 prefix.

Completed Tasks:

Replace I64x/I64X format specifiers with PRIx64/PRIX64 macro in dasm.cpp (10 instances)
Replace I64x format specifiers with PRIx64 macro in mdinfo.cpp (2 instances)
Build the CoreCLR component successfully on Linux
Test the changes - verified correct output
Fix Windows build error by removing cinttypes include

Verification Results:

✅ Build: CoreCLR built successfully on Linux with no warnings or errors
✅ Functionality: Tested ildasm with System.Private.CoreLib.dll

Before fix (broken on Linux):

//    Metadata Stream Header:
//      0x%016I64x MaskValid
//      0x%016I64x Sorted

After fix (working correctly):

//    Metadata Stream Header:
//      0x00001f013fb7bf55 MaskValid
//      0x00c416003301fa00 Sorted

All 64-bit values in ildasm output are now formatted correctly on Linux.

Files Modified:

src/coreclr/ildasm/dasm.cpp - Fixed 10 format specifiers
src/coreclr/tools/metainfo/mdinfo.cpp - Fixed 2 format specifiers

Total: 12 format specifiers fixed across 2 files

Technical Details:

Replaced non-standard Microsoft-specific I64x/I64X format specifiers with standard C99 PRIx64/PRIX64 macros
Changed casts from ULONGLONG to uint64_t for compatibility with the standard macros
The PRI macros (PRIx64/PRIX64) are already available through src/native/minipal/types.h which is included via the build system
No need to explicitly include <cinttypes> - this was causing Windows build errors due to macro redefinition

The standard macros expand to the correct format specifier for each platform (e.g., "lx" on Linux, "I64x" on Windows), ensuring cross-platform compatibility.

Fixes #121686

Original prompt

This section details on the original issue you should resolve

<issue_title>Incorrect ildasm output due to invalid printf format string.</issue_title>
<issue_description>### Description

On Linux, with the code from the current main branch, 64-bit values are not all formatted correctly.

Reproduction Steps

Build on Linux, run artifacts/bin/coreclr/linux.x64.Debug/ildasm -all artifacts/bin/coreclr/linux.x64.Debug/IL/System.Private.CoreLib.dll

Expected behavior

The following would be expected:
//    Metadata Stream Header:
//              0x00000000 Reserved
//                    0x02 Major
//                    0x00 Minor
//                    0x05 Heaps
//                    0x0a Rid
//      0x00001f013fb7bf55 MaskValid
//      0x00c416003301fa00 Sorted
Actual behavior

Instead ildasm produces the following output:
//    Metadata Stream Header:
//              0x00000000 Reserved
//                    0x02 Major
//                    0x00 Minor
//                    0x05 Heaps
//                    0x0a Rid
//      0x%016I64x MaskValid
//      0x%016I64x Sorted
Regression?

No.

Known Workarounds

None known.

Configuration

Version: current main.
OS: Debian Linux.
Architecture: x64.
Probably not distro- or architecture-specific.

Other information

This is because the non-standard prefix I64 is used in format strings. The glibc's printf family of function does not recognize I64.
I64x, I64d, I64u, I64i are used in many places, see the output from git grep I64[IiUuDdXx] main -- *.cpp in I64.txt
Suggestion: use the standard PRIx64, PRId64 etc. macros from <cinttypes> instead. Example:
--- a/src/coreclr/ildasm/dasm.cpp
+++ b/src/coreclr/ildasm/dasm.cpp
@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#include <cinttypes>
 #include "ildasmpch.h"
 #include <crtdbg.h>
 #include <utilcode.h>
@@ -5460,9 +5461,9 @@ void DumpMetadataHeader(const char *szName, IMAGE_DATA_DIRECTORY *pDir, void* GU
         printLine(GUICookie,szStr);
         sprintf_s(szString,SZSTRING_SIZE,"//                    0x%02x Rid", pMDSH->Rid);
         printLine(GUICookie,szStr);
-        sprintf_s(szString,SZSTRING_SIZE,"//      0x%016I64x MaskValid", (ULONGLONG)GET_UNALIGNED_VAL64(&(pMDSH->MaskValid)));
+        sprintf_s(szString,SZSTRING_SIZE,"//      0x%016" PRIx64 " MaskValid", (uint64_t)GET_UNALIGNED_VAL64(&(pMDSH->MaskValid)));
         printLine(GUICookie,szStr);
-        sprintf_s(szString,SZSTRING_SIZE,"//      0x%016I64x Sorted", (ULONGLONG)GET_UNALIGNED_VAL64(&(pMDSH->Sorted)));
+        sprintf_s(szString,SZSTRING_SIZE,"//      0x%016" PRIx64 " Sorted", (uint64_t)GET_UNALIGNED_VAL64(&(pMDSH->Sorted)));
         printLine(GUICookie,szStr);
     }
 }
```</issue_description>

<agent_instructions>Use the standard PRIx64, PRId64 etc. macros. Look for other instances of the same bug.</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes Incorrect ildasm output due to invalid printf format string. #121686

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Replace non-standard I64x/I64X format specifiers with C99 standard PRIx64/PRIX64 macros from <cinttypes> in ildasm and metainfo tools. This fixes incorrect output on Linux where glibc doesn't recognize I64 prefix. Changes: - Add #include <cinttypes> to dasm.cpp and mdinfo.cpp - Replace all I64x format specifiers with PRIx64 - Replace I64X with PRIX64 for uppercase hex - Cast ULONGLONG to uint64_t for consistency with PRIx64 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

am11 · 2025-11-16T22:28:54Z

There are (110) MSFT-specific format specifiers used in the repo, @copilot has only updated 13 of them:

# Finds MSVC-specific format specifiers with flags, width, and precision:
# Covers: %I64d, %016I64x, %.8I64u, %#016I64X, %+08I32d, %-16Ix, etc.
# Flags: -, #, 0, space, +
# Width: any number (e.g., 016, 8)
# Precision: .followed by number (e.g., .16, .8)
# Type suffix: I64, I32, or just I (for size_t)
# Format: d, i, o, u, x, X
$ git grep -nE '%[0-9.]*I(64|32)?[diouxX]' | tee

src/coreclr/debug/di/rsmain.cpp:1695:    LOG((LF_CORDB, LL_EVERYTHING, "Handle in Cordb::CreateProcess is: %.I64x\n", lpProcessInformation->hProcess));
src/coreclr/gc/gc.cpp:1406:        dprintf (5555, ("h%d RETRY %s(%Id)", heap_number, msg, size)); \
src/coreclr/gc/gc.cpp:7143:                dprintf (6666, ("gc#0 thread waiting for %d ms (betwen GCs %I64d)", wait_time, sample.elapsed_between_gcs));
src/coreclr/gc/gc.cpp:7148:            dprintf (9999, ("waiting for ee done res %d (timeout %d, %I64d ms since last suspend end)(should_change_heap_count is %d) (gradual_decommit_in_progress_p %d)",
src/coreclr/gc/gc.cpp:7249:            dprintf (9999, ("GC thread %d waiting_for_gc_start(%d)(gc%Id)", heap_number, n_heaps, VolatileLoadWithoutBarrier(&settings.gc_index)));
src/coreclr/gc/gc.cpp:7252:            dprintf (9999, ("GC thread %d waiting_done_gc_start(%d-%d)(i: %d)(gc%Id)",
src/coreclr/gc/gc.cpp:7284:                            dprintf (9999, ("GC thread %d wait_on_idle(%d < %d)(gc%Id), total idle %d", heap_number, old_n_heaps, new_n_heaps,
src/coreclr/gc/gc.cpp:7287:                            dprintf (9999, ("GC thread %d waking_from_idle(%d)(gc%Id) after doing change", heap_number, n_heaps, VolatileLoadWithoutBarrier (&settings.gc_index)));
src/coreclr/gc/gc.cpp:7300:                    dprintf (9999, ("GC thread %d wait_on_idle(< max %d)(gc%Id), total  idle %d", heap_number, num_threads_to_wake,
src/coreclr/gc/gc.cpp:7303:                    dprintf (9999, ("GC thread %d waking_from_idle(%d)(gc%Id)", heap_number, n_heaps, VolatileLoadWithoutBarrier (&settings.gc_index)));
src/coreclr/gc/gc.cpp:16315:            dprintf (3, ("b#%2d FL %Ix region %Ix heap %d -> %d",
src/coreclr/gc/gc.cpp:16327:    dprintf (3, ("total - %Id items out of %Id items are from a different heap in %I64d us",
src/coreclr/gc/gc.cpp:16411:            dprintf (3, ("b#%2d FL %Ix region %Ix heap %d -> %d",
src/coreclr/gc/gc.cpp:16447:    dprintf (8888, ("h%d total %Id items rethreaded out of %Id items in %I64d us (%I64dms)",
src/coreclr/gc/gc.cpp:18715:        dprintf (3, ("h%d alloc-ed too much before bgc started, last end %Id, this start %Id, wait",
src/coreclr/gc/gc.cpp:18771:        dprintf (3, ("h%d g%d size is now %Id (inc-ed %Id), size is %Id (gen size is %Id), budget %.3fmb, new alloc %.3fmb",
src/coreclr/gc/gc.cpp:19146:        //dprintf (5555, ("h%d TAMS g%d %Id returning a_state_retry_allocate!", heap_number, gen_number, size));
src/coreclr/gc/gc.cpp:19711:                dprintf (3, ("uoh alloc %Id on h%d", size, alloc_heap->heap_number));
src/coreclr/gc/gc.cpp:19718:            dprintf (3, ("UOH h%d %Id returned from TAMS, s %d", alloc_heap->heap_number, size, status));
src/coreclr/gc/gc.cpp:19725:                dprintf (5555, ("UOH h%d alloc %Id retry!", alloc_heap->heap_number, size));
src/coreclr/gc/gc.cpp:19731:                    dprintf (5555, ("UOH h%d allocated %Id on retry (%I64dus)", alloc_heap->heap_number, size, (end_us - start_us)));
src/coreclr/gc/gc.cpp:21611:    dprintf (GC_TABLE_LOG, ("new seg %Ix, mark_array is %Ix",
src/coreclr/gc/gc.cpp:21616:        dprintf (GC_TABLE_LOG, ("failed to commit mark array for the new region %Ix-%Ix",
src/coreclr/gc/gc.cpp:21684:        dprintf (3, ("h%d g%d FLa: %Id, ESa: %Id, Ca: %Id | FO: %Id, FL %Id, fl effi %.3f, unusable fl is %Id",
src/coreclr/gc/gc.cpp:22499:            dprintf (3, ("prev gen%d GC end time: prev start %I64d + prev gc elapsed %Id = %I64d",
src/coreclr/gc/gc.cpp:22507:            dprintf (3, ("updated NGC%d %Id elapsed time to %I64d - %I64d = %I64d", gen_number, dd_gc_clock (dd), end_gc_time, dd_time_clock (dd), dd_gc_elapsed_time (dd)));
src/coreclr/gc/gc.cpp:22664:            dprintf (6666, ("BGC %Id end %I64d - (prev gen2 start %I64d + elapsed %Id = %I64d) = time inbewteen gen2 %Id",
src/coreclr/gc/gc.cpp:22673:            dprintf (6666, ("updating BGC %Id elapsed time to %I64d - %I64d = %I64d", dd_gc_clock (dd), end_gc_time, dd_time_clock (dd), dd_gc_elapsed_time (dd)));
src/coreclr/gc/gc.cpp:22680:            dprintf (6666, ("gen2 sample %d elapsed %Id * 100 / time inbetween gen2 %Id = %.3f",
src/coreclr/gc/gc.cpp:23038:                    dprintf (6666, ("final gen0 bcs: total desired: %Id (%.3fmb/heap), before smooth %zd -> after smooth %zd -> after joined %zd",
src/coreclr/gc/gc.cpp:23331:    dprintf (8888, ("rethreaded %Id items, merging took %I64dus (%I64dms)",
src/coreclr/gc/gc.cpp:23397:    dprintf (8888, ("total %Id fl items, %Id are for other heaps",
src/coreclr/gc/gc.cpp:25823:    dprintf (6666, ("current num of samples %Id (g2: %Id) prev processed %Id (g2: %Id), last full GC happened at index %Id",
src/coreclr/gc/gc.cpp:25858:            dprintf (6666, ("sample %d in GC#%Id msl %I64d / %d + pause %I64d / elapsed %I64d = tcp: %.3f, surv %zd, gc speed %zd/ms", i,
src/coreclr/gc/gc.cpp:25878:    dprintf (6666, ("checking if samples are stable %Id %Id %Id, min tcp %.3f, min pause %I64d",
src/coreclr/gc/gc.cpp:25889:            dprintf (6666, ("sample %d diff from min is %Id -> %.3f", i, (sample.gc_survived_size - min_survived), diff));
src/coreclr/gc/gc.cpp:26028:            dprintf (6666, ("changing HC or budget %d -> %d at GC#%Id", n_heaps, new_n_heaps, current_gc_index));
src/coreclr/gc/gc.cpp:26086:                dprintf (6666, ("[CHP3-0] last gen2 sample count when changed: %Id, gen2 tcp: %.3f, dec by %d, %d -> %d",
src/coreclr/gc/gc.cpp:26102:        dprintf (6666, ("processed eph samples, updating processed %Id -> %Id", dynamic_heap_count_data.processed_samples_count, dynamic_heap_count_data.current_samples_count));
src/coreclr/gc/gc.cpp:26123:        dprintf (6666, ("processed gen2 samples, updating processed %Id -> %Id", dynamic_heap_count_data.processed_gen2_samples_count, dynamic_heap_count_data.current_gen2_samples_count));
src/coreclr/gc/gc.cpp:26130:        dprintf (6666, ("GC#%Id should change! %d->%d (%s)",
src/coreclr/gc/gc.cpp:26164:        dprintf (6666, ("prep to change from %d to %d at GC#%Id", n_heaps, dynamic_heap_count_data.new_n_heaps, VolatileLoadWithoutBarrier (&settings.gc_index)));
src/coreclr/gc/gc.cpp:26180:        dprintf (6666, ("heap count stays the same %d, no work to do, set processed sample count to %Id",
src/coreclr/gc/gc.cpp:26663:            dprintf (6666, ("g%d: total budget %zd (%zd / heap), left in budget: %zd (%zd / heap), (allocated %Id, %.3f%%), min %zd",
src/coreclr/gc/gc.cpp:26746:        dprintf (6666, ("changing HC took %I64dus", change_heap_count_time));
src/coreclr/gc/gc.cpp:26800:        dprintf (6666, ("gen0 new_alloc %Id (%.3fmb), from datas: %Id (%.3fmb)",
src/coreclr/gc/gc.cpp:26802:        dprintf (6666, ("budget DATAS %Id, previous %Id", desired_per_heap_datas, desired_per_heap));
src/coreclr/gc/gc.cpp:26811:        dprintf (6666, ("sample#%d: %d heaps, this GC end %I64d - last sus end %I64d = %I64d, this GC pause %.3fms, msl wait %I64dus, tcp %.3f, surv %zd, gc speed %.3fmb/ms (%.3fkb/ms/heap)",
src/coreclr/gc/gc.cpp:26842:            dprintf (6666, ("gen2 sample#%d: this GC end %I64d - last gen2 end %I64d = %I64d, GC elapsed %I64d, percent %.3f",
src/coreclr/gc/gc.cpp:26866:    dprintf (6666, ("h%d ADDING %s HC hist to entry #%d, stage %d, gc index %Id, last %d, n %d, new %d",
src/coreclr/gc/gc.cpp:30438:        dprintf (6666, ("h%d skip ratio soh: %d (n_gen_soh: %Id, n_eph_soh: %Id), loh: %d (n_gen_loh: %Id, n_eph_loh: %Id), size 0: %Id-%Id, 1: %Id-%Id, 2: %Id-%Id, 3: %Id-%Id",
src/coreclr/gc/gc.cpp:32220:        dprintf (REGIONS_LOG, ("h%d gen%d region %Ix will be empty", heap_number, heap_segment_gen_num (region), heap_segment_mem (region)));
src/coreclr/gc/gc.cpp:32260:    dprintf (REGIONS_LOG, ("h%d PLN: (%s) plan gen%d->%d, consing alloc region: %p, ptr: %p (%Id) (consing gen: %d)",
src/coreclr/gc/gc.cpp:32385:                    dprintf (REGIONS_LOG, ("we still have a pin at %Ix but no more regions!?", pinned_plug (oldest_pin ())));
src/coreclr/gc/gc.cpp:32429:    dprintf (REGIONS_LOG, ("h%d g2: surv %Id(p: %Id, %.2f%%), g1: surv %Id(p: %Id, %.2f%%), g0: surv %Id(p: %Id, %.2f%%)",
src/coreclr/gc/gc.cpp:32489:        dprintf (REGIONS_LOG, ("h%d ad_p_d: PL: %zd, SL: %zd, pfr: %.3f, psr: %.3f, prmoote gen1 %d. gen1_pins_left %Id, total surv %Id (p:%Id), total_space %Id",
src/coreclr/gc/gc.cpp:39769:        dprintf (5555, ("h%d replacing mark list at %Ix with %Ix", heap_number, (size_t)c_mark_list, (size_t)new_c_mark_list));
src/coreclr/gc/gc.cpp:39855:        dprintf (6666, ("ADDING to BGC th hist entry%d gc index %Id, created %d, %d th existed, %d failed",
src/coreclr/gc/gc.cpp:40193:            dprintf (6666, ("BGC%Id h%d going idle (%d heaps), idle count is now %d",
src/coreclr/gc/gc.cpp:40196:            dprintf (6666, ("BGC%Id h%d woke from idle (%d heaps), idle count is now %d",
src/coreclr/gc/gc.cpp:47775:        dprintf (REGIONS_LOG, ("[%s] GC#%5Id [%s] heap %Idmb (F: %Idmb %d%%) commit size: %Idmb, %0.3f min, %d,%d new in plan, %d in threading",
src/coreclr/gc/gc.cpp:47792:        dprintf (REGIONS_LOG, ("[%s] GC#%Id (bgcs: %d, %s) g0: %Idmb (f: %Idmb %d%%), g1: %Idmb (f: %Idmb %d%%), g2: %Idmb (f: %Idmb %d%%), g3: %Idmb (f: %Idmb %d%%)",
src/coreclr/gc/gc.cpp:47802:            dprintf (1, ("[%5s] GC#%5Id total heap size: %Idmb (F: %Idmb %d%%) commit size: %Idmb, %0.3f min, %d,%d new in plan, %d in threading\n",
src/coreclr/gc/gc.cpp:49679:            dprintf (6666, ("DATAS gen0 growth multiplier will be adjusted by %d%%, cap %.3f-%.3f, min budget %Id, max %Id",
src/coreclr/gc/gc.cpp:50977:    cprintf (("%2d | %6d | %1d | %1s | %2s | %2s | %2s | %2s | %2s || %5Id | %5Id | %5Id | %5Id | %5Id | %5Id | %5Id | %5Id | %5Id |",
src/coreclr/gc/gcpriv.h:3051:            dprintf (3, ("last plug: %Ix, last plug reloc: %Ix, before last: %Ix, b: %Ix",
src/coreclr/gc/gcpriv.h:4487:                    dprintf (6666, ("last adjustment was also budget at GC#%Id, inc count to %d", adj->gc_index, adj->count));
src/coreclr/gc/gcpriv.h:4499:            dprintf (6666, ("recording adjustment %s at #%d GC#%Id - distance to target %.3f, changed %d HC",
src/coreclr/gc/gcpriv.h:4709:            dprintf (6666, ("last adjusted at GC#%Id, %Id GCs ago, %s",
src/coreclr/gc/gcpriv.h:4772:            dprintf (6666, ("we adjusted at GC#%Id, %Id GCs ago", last_changed_gc_index, *num_gcs_since_last_change));
src/coreclr/gc/gcpriv.h:4776:                dprintf (6666, ("we just adjusted %Id GCs ago, skipping", *num_gcs_since_last_change));
src/coreclr/gc/gcpriv.h:4910:                dprintf (6666, ("dec: last HC change %d heaps at GC#%Id, factor %d", last_hc_change, last_change_gc_index, factor));
src/coreclr/gc/gcpriv.h:4928:                        dprintf (6666, ("before last was %d heaps at GC#%Id (%Id GCs), factor is now %d",
src/coreclr/gc/gcpriv.h:5044:                    dprintf (6666, ("we've changed budget instead of HC %d times from %Id GCs ago, thres %d times",
src/coreclr/gc/gcpriv.h:5056:                    dprintf (6666, ("It's been %Id GCs since we changed last time, thres %d GCs, %s",
src/coreclr/gc/gcpriv.h:5100:            dprintf (6666, ("stable soh %Id (%.3fmb), factor %.3f=>%.3f -> total gen0 new_alloc %Id (%.3fmb)",
src/coreclr/gc/gcpriv.h:5121:            dprintf (6666, ("BCD: %Id/heap (%.3fmb) -> %.3fmb, BCS %Id/heap (%.3fmb)",
src/coreclr/gc/gcpriv.h:5146:                dprintf (6666, ("last gc gen0 budget %Id, last adjustment %s was at GC#%Id, last BGC was #%Id, this GC #%Id, %s",
src/coreclr/gc/gcpriv.h:5174:                        dprintf (6666, ("adjust last budget %Id to %Id->%Id (%.3fmb)",
src/coreclr/gc/gcpriv.h:5182:            dprintf (6666, ("taking min of the two: %Id, %Id", bcs_per_heap, budget_old_gen_per_heap));
src/coreclr/ildasm/dasm.cpp:5463:        sprintf_s(szString,SZSTRING_SIZE,"//      0x%016I64x MaskValid", (ULONGLONG)GET_UNALIGNED_VAL64(&(pMDSH->MaskValid)));
src/coreclr/ildasm/dasm.cpp:5465:        sprintf_s(szString,SZSTRING_SIZE,"//      0x%016I64x Sorted", (ULONGLONG)GET_UNALIGNED_VAL64(&(pMDSH->Sorted)));
src/coreclr/ildasm/dasm.cpp:5683:        sprintf_s(szString,SZSTRING_SIZE,"// Image base:                     0x%016I64x", VAL64(pOptHeader->ImageBase));
src/coreclr/ildasm/dasm.cpp:5711:        sprintf_s(szString,SZSTRING_SIZE,"// Size of stack reserve:          0x%016I64x", VAL64(pOptHeader->SizeOfStackReserve));
src/coreclr/ildasm/dasm.cpp:5713:        sprintf_s(szString,SZSTRING_SIZE,"// Size of stack commit:           0x%016I64x", VAL64(pOptHeader->SizeOfStackCommit));
src/coreclr/ildasm/dasm.cpp:5715:        sprintf_s(szString,SZSTRING_SIZE,"// Size of heap reserve:           0x%016I64x", VAL64(pOptHeader->SizeOfHeapReserve));
src/coreclr/ildasm/dasm.cpp:5717:        sprintf_s(szString,SZSTRING_SIZE,"// Size of heap commit:            0x%016I64x", VAL64(pOptHeader->SizeOfHeapCommit));
src/coreclr/ildasm/dasm.cpp:6750:        sprintf_s(szString,SZSTRING_SIZE,"%s%s 0x%016I64x", g_szAsmCodeIndent,KEYWORD(".imagebase"),VAL64(pOptHeader64->ImageBase));
src/coreclr/ildasm/dasm.cpp:6755:        sprintf_s(szString,SZSTRING_SIZE,"%s%s 0x%016I64x", g_szAsmCodeIndent,KEYWORD(".stackreserve"),VAL64(pOptHeader64->SizeOfStackReserve));
src/coreclr/ildasm/dasm.cpp:6870:                                    szptr+=sprintf_s(szptr,SZSTRING_REMAINING_SIZE(szptr)," %016I64X", VAL64(*(uint64_t *)pSlot));
src/coreclr/jit/compiler.cpp:1500:    jitprintf("Allocated %6I64u tree nodes (%7I64u bytes total, avg %4I64u bytes per method)\n",
src/coreclr/jit/compiler.cpp:1504:    jitprintf("Allocated %7I64u bytes of unused tree node space (%3.2f%%)\n",
src/coreclr/jit/disasm.cpp:374:    DISASM_DUMP("FixupMember %016I64X (%08IX), size %d, termType %u\n", addr, disGetLinearAddr((size_t)addr), size,
src/coreclr/jit/disasm.cpp:476:    DISASM_DUMP("FixupMember %016I64X (%08IX), size %d, termType %u\n", addr, disGetLinearAddr((size_t)addr), size,
src/coreclr/jit/disasm.cpp:1512:        fprintf(disAsmFile, "************************** %hs:%hs size 0x%04IX **************************\n\n",
src/coreclr/jit/disasm.cpp:1520:                "************************** %hs:%hs hot size 0x%04IX cold size 0x%04IX **************************\n\n",
src/coreclr/jit/gentree.cpp:12277:            printf(" 0x%016I64x", tree->AsLngCon()->gtLconVal);
src/coreclr/nativeaot/Runtime/UniversalTransitionHelpers.cpp:32:// %I64d/%f rendering of the combined 64-bit value of each aligned pair of 32-bit values.
src/coreclr/pal/tests/palsuite/c_runtime/sscanf_s/sscanf_s.h:141:        sprintf_s(buf, ARRAY_SIZE(buf), "%I64d", num);
src/coreclr/pal/tests/palsuite/c_runtime/sscanf_s/sscanf_s.h:142:        sprintf_s(check, ARRAY_SIZE(check), "%I64d", checknum);
src/coreclr/pal/tests/palsuite/c_runtime/sscanf_s/test4/test4.cpp:39:    DoI64NumTest("4294967296", "%I64d", 4294967296LL);
src/coreclr/pal/tests/palsuite/c_runtime/sscanf_s/test5/test5.cpp:38:    DoI64NumTest("4294967296", "%I64i", 4294967296LL);
src/coreclr/pal/tests/palsuite/c_runtime/sscanf_s/test6/test6.cpp:38:    DoI64NumTest("40000000000", "%I64o", 4294967296LL);
src/coreclr/pal/tests/palsuite/c_runtime/sscanf_s/test7/test7.cpp:38:    DoI64NumTest("100000000", "%I64x", 4294967296LL);
src/coreclr/pal/tests/palsuite/c_runtime/sscanf_s/test8/test8.cpp:38:    DoI64NumTest("4294967296", "%I64u", 4294967296LL);
src/coreclr/tools/metainfo/mdinfo.cpp:3951:            VWriteLine("Metadata header: %d.%d, heaps: 0x%02x, rid: 0x%02x, valid: 0x%016I64x, sorted: 0x%016I64x",
src/native/managed/cdac/tests/PrintfStressMessageFormatterTests.cs:105:        foreach (string specifier in new[] { "%u", "%lu", "%llu", "%zu", "%I64u" })
src/native/managed/cdac/tests/PrintfStressMessageFormatterTests.cs:126:        foreach (string specifier in new[] { "%x", "%X", "%llx", "%llX", "%zx", "%zX", "%Ix" })
src/tests/JIT/Methodical/structs/systemvbringup/structinregs.cpp:330:    printf("Native S20: %I64d, %I64d, %I64d, %I64d\n", s.x, s.y, s.z, s.w);
src/tests/JIT/Methodical/structs/systemvbringup/structinregs.cpp:474:    printf("Native S20: %I64d, %I64d, %I64d, %I64d\n", s.x, s.y, s.z, s.w);

jkotas · 2025-11-16T22:54:44Z

@copilot Fix build breaks:

C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\arm64\cl.exe  /nologo /TP -DBUILDENV_CHECKED=1 -DDEBUG -DDEBUGGING_SUPPORTED -DDISABLE_CONTRACTS -DFEATURE_BASICFREEZE -DFEATURE_CODE_VERSIONING -DFEATURE_COLLECTIBLE_TYPES -DFEATURE_COMINTEROP -DFEATURE_COMINTEROP_APARTMENT_SUPPORT -DFEATURE_COMINTEROP_UNMANAGED_ACTIVATION -DFEATURE_COMWRAPPERS -DFEATURE_CORECLR -DFEATURE_CORECLR_FLUSH_INSTRUCTION_CACHE_TO_PROTECT_STUB_READS -DFEATURE_DEFAULT_INTERFACES -DFEATURE_EH_FUNCLETS -DFEATURE_EVENT_TRACE -DFEATURE_HIJACK -DFEATURE_IJW -DFEATURE_INTEROP_DEBUGGING -DFEATURE_INTERPRETER -DFEATURE_ISYM_READER -DFEATURE_JAVAMARSHAL -DFEATURE_JIT -DFEATURE_MANUALLY_MANAGED_CARD_BUNDLES -DFEATURE_METADATA_UPDATER -DFEATURE_MULTICOREJIT -DFEATURE_PERFTRACING -DFEATURE_PGO -DFEATURE_PROFAPI_ATTACH_DETACH -DFEATURE_READYTORUN -DFEATURE_REJIT -DFEATURE_REMAP_FUNCTION -DFEATURE_SPECIAL_USER_MODE_APC -DFEATURE_STANDALONE_GC -DFEATURE_SVR_GC -DFEATURE_SYMDIFF -DFEATURE_TIERED_COMPILATION -DFEATURE_TYPEEQUIVALENCE -DFEATURE_USE_ASM_GC_WRITE_BARRIERS -DFEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP -DFX_VER_INTERNALNAME_STR=ildasm.exe -DHOST_64BIT -DHOST_ARM64 -DHOST_WINDOWS -DNOMINMAX -DPROFILING_SUPPORTED -DTARGET_64BIT -DTARGET_ARM64 -DTARGET_WINDOWS -DUNICODE -DURTBLDENV_FRIENDLY=Checked -DWIN32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x0602 -D_CRT_SECURE_NO_WARNINGS -D_DBG -D_DEBUG -D_FEATURE_NO_HOST -D_FILE_OFFSET_BITS=64 -D_SECURE_SCL=0 -D_TIME_BITS=64 -D_UNICODE -D_WIN32 -D_WIN32_WINNT=0x0602 -D__ILDASM__ -ID:\a\_work\1\s\src\native -ID:\a\_work\1\s\src\native\inc -ID:\a\_work\1\s\src\coreclr\pal\prebuilt\inc -ID:\a\_work\1\s\artifacts\obj -ID:\a\_work\1\s\src\coreclr\inc -ID:\a\_work\1\s\src\coreclr\debug\inc -ID:\a\_work\1\s\src\coreclr\debug\inc\arm64 -ID:\a\_work\1\s\src\coreclr\debug\inc\dump -ID:\a\_work\1\s\src\coreclr\md\inc -ID:\a\_work\1\s\src\coreclr\classlibnative\bcltype -ID:\a\_work\1\s\src\coreclr\classlibnative\inc -ID:\a\_work\1\s\artifacts\obj\coreclr\windows.arm64.Checked\inc -ID:\a\_work\1\s\src\coreclr\hosts\inc -ID:\a\_work\1\s\src\coreclr\interpreter\inc -ID:\a\_work\1\s\src\coreclr\minipal -ID:\a\_work\1\s\artifacts\obj\coreclr\windows.arm64.Checked\inc\etw -ID:\a\_work\1\s\src\coreclr\ildasm\exe\.. /DWIN32 /D_WINDOWS  /GR- -std:c++17 -MTd /O2 /EHa /nologo /W4 /WX /sdl /Oi /Oy- /Gm- /Zp8 /Gy /fp:precise /FC /MP /Zm200 /Zc:strictStrings /Zc:wchar_t /Zc:inline /Zc:forScope /wd4065 /wd4100 /wd4127 /wd4131 /wd4189 /wd4200 /wd4201 /wd4206 /wd4239 /wd4245 /wd4291 /wd4310 /wd4324 /wd4366 /wd4456 /wd4457 /wd4458 /wd4459 /wd4463 /wd4505 /wd4702 /wd4706 /wd4733 /wd4815 /wd4838 /wd4918 /wd4960 /wd4961 /wd5105 /wd5205 /we4007 /we4013 /we4102 /we4551 /we4640 /we4806 /w34092 /w34121 /w34125 /w34130 /w34132 /w34212 /w34530 /w35038 /w44177 /Zi /ZH:SHA_256 /source-charset:utf-8 /guard:cf /Zl /showIncludes /Foildasm\exe\CMakeFiles\ildasm.dir\__\dasm_mi.cpp.obj /Fdildasm\exe\CMakeFiles\ildasm.dir\ /FS -c D:\a\_work\1\s\src\coreclr\ildasm\dasm_mi.cpp
  C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\inttypes.h(174): error C2220: the following warning is treated as an error
  C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\inttypes.h(174): warning C4005: 'PRIu64': macro redefinition
  D:\a\_work\1\s\src\native\minipal\types.h(24): note: see previous definition of 'PRIu64'
  C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\inttypes.h(193): warning C4005: 'PRIx64': macro redefinition
  D:\a\_work\1\s\src\native\minipal\types.h(20): note: see previous definition of 'PRIx64'
  C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\inttypes.h(212): warning C4005: 'PRIX64': macro redefinition
  D:\a\_work\1\s\src\native\minipal\types.h(16): note: see previous definition of 'PRIX64'

jkotas · 2025-11-16T22:55:27Z

There are (110) MSFT-specific format specifiers used in the repo, https://gh.io/copilot-coding-agent-docs has only updated 13 of them:

@copilot Please address this feedback above

The PRIx64/PRIX64 macros are already defined in src/native/minipal/types.h which gets included through the build system. Including <cinttypes> causes macro redefinition errors on Windows where both headers define these macros. The fix still works correctly on Linux without the explicit include. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2025-11-16T23:16:00Z

@copilot Fix build breaks:

C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\arm64\cl.exe  /nologo /TP -DBUILDENV_CHECKED=1 -DDEBUG -DDEBUGGING_SUPPORTED -DDISABLE_CONTRACT...

Fixed in ff01ff5. Removed the #include <cinttypes> lines since the PRIx64/PRIX64 macros are already defined in src/native/minipal/types.h which gets included through the build system. The explicit include was causing macro redefinition errors on Windows.

Copilot · 2025-11-16T23:39:08Z

There are (110) MSFT-specific format specifiers used in the repo, https://gh.io/copilot-coding-agent-docs has only updated 13 of them:

@copilot Please address this feedback above

I found 27 instances of I64 format specifiers in the codebase. Could you clarify:

Where are the 110 instances you mentioned? Should I search in a different scope (e.g., including .h files, other directories)?
Should I fix all I64 format specifiers, or only those in user-facing output like ildasm? Many of the remaining instances are in:
- Debug logging (gc.cpp dprintf statements)
- JIT diagnostics
- Test files

Please let me know which areas need to be updated.

jkotas · 2025-11-17T00:08:39Z

@copilot Fix Debug logging, JIT diagnostics and JIT methodical tests

src/coreclr/debug/di/rsmain.cpp:1695: src/coreclr/gc/gc.cpp:1406: src/coreclr/gc/gc.cpp:7143: src/coreclr/gc/gc.cpp:7148: src/coreclr/gc/gc.cpp:7249: src/coreclr/gc/gc.cpp:7252: src/coreclr/gc/gc.cpp:7284: src/coreclr/gc/gc.cpp:7287: src/coreclr/gc/gc.cpp:7300: src/coreclr/gc/gc.cpp:7303: src/coreclr/gc/gc.cpp:16315: src/coreclr/gc/gc.cpp:16327: src/coreclr/gc/gc.cpp:16411: src/coreclr/gc/gc.cpp:16447: src/coreclr/gc/gc.cpp:18715: src/coreclr/gc/gc.cpp:18771: src/coreclr/gc/gc.cpp:19146: src/coreclr/gc/gc.cpp:19711: src/coreclr/gc/gc.cpp:19718: src/coreclr/gc/gc.cpp:19725: src/coreclr/gc/gc.cpp:19731: src/coreclr/gc/gc.cpp:21611: src/coreclr/gc/gc.cpp:21616: src/coreclr/gc/gc.cpp:21684: src/coreclr/gc/gc.cpp:22499: src/coreclr/gc/gc.cpp:22507: src/coreclr/gc/gc.cpp:22664: src/coreclr/gc/gc.cpp:22673: src/coreclr/gc/gc.cpp:22680: src/coreclr/gc/gc.cpp:23038: src/coreclr/gc/gc.cpp:23331: src/coreclr/gc/gc.cpp:23397: src/coreclr/gc/gc.cpp:25823: src/coreclr/gc/gc.cpp:25858: src/coreclr/gc/gc.cpp:25878: src/coreclr/gc/gc.cpp:25889: src/coreclr/gc/gc.cpp:26028: src/coreclr/gc/gc.cpp:26086: src/coreclr/gc/gc.cpp:26102: src/coreclr/gc/gc.cpp:26123: src/coreclr/gc/gc.cpp:26130: src/coreclr/gc/gc.cpp:26164: src/coreclr/gc/gc.cpp:26180: src/coreclr/gc/gc.cpp:26663: src/coreclr/gc/gc.cpp:26746: src/coreclr/gc/gc.cpp:26800: src/coreclr/gc/gc.cpp:26802: src/coreclr/gc/gc.cpp:26811: src/coreclr/gc/gc.cpp:26842: src/coreclr/gc/gc.cpp:26866: src/coreclr/gc/gc.cpp:30438: src/coreclr/gc/gc.cpp:32220: src/coreclr/gc/gc.cpp:32260: src/coreclr/gc/gc.cpp:32385: src/coreclr/gc/gc.cpp:32429: src/coreclr/gc/gc.cpp:32489: src/coreclr/gc/gc.cpp:39769: src/coreclr/gc/gc.cpp:39855: src/coreclr/gc/gc.cpp:40193: src/coreclr/gc/gc.cpp:40196: src/coreclr/gc/gc.cpp:47775: src/coreclr/gc/gc.cpp:47792: src/coreclr/gc/gc.cpp:47802: src/coreclr/gc/gc.cpp:49679: src/coreclr/gc/gc.cpp:50977: src/coreclr/gc/gcpriv.h:3051: src/coreclr/gc/gcpriv.h:4487: src/coreclr/gc/gcpriv.h:4499: src/coreclr/gc/gcpriv.h:4709: src/coreclr/gc/gcpriv.h:4772: src/coreclr/gc/gcpriv.h:4776: src/coreclr/gc/gcpriv.h:4910: src/coreclr/gc/gcpriv.h:4928: src/coreclr/gc/gcpriv.h:5044: src/coreclr/gc/gcpriv.h:5056: src/coreclr/gc/gcpriv.h:5100: src/coreclr/gc/gcpriv.h:5121: src/coreclr/gc/gcpriv.h:5146: src/coreclr/gc/gcpriv.h:5174: src/coreclr/gc/gcpriv.h:5182: src/coreclr/jit/compiler.cpp:1500: src/coreclr/jit/compiler.cpp:1504: src/coreclr/jit/disasm.cpp:374: src/coreclr/jit/disasm.cpp:476: src/coreclr/jit/disasm.cpp:1512: src/coreclr/jit/disasm.cpp:1520: src/coreclr/jit/gentree.cpp:12277: src/tests/JIT/Methodical/str src/tests/JIT/Methodical/str LOG((LF_CORDB, LL_EVERYTHING, "Handle in Cordb::CreateProcess is: %.I64x\n", lpProcessInformation->hProcess));
dprintf (5555, ("h%d RETRY %s(%Id)", heap_number, msg, size));
dprintf (6666, ("gc#0 thread waiting for %d ms (betwen GCs %I64d)", wait_time, sample.elapsed_between_gcs));
dprintf (9999, ("waiting for ee done res %d (timeout %d, %I64d ms since last suspend end)(should_change_heap_count is %d) (gradual_decommit_in_progress_p %d)",
dprintf (9999, ("GC thread %d waiting_for_gc_start(%d)(gc%Id)", heap_number, n_heaps, VolatileLoadWithoutBarrier(&settings.gc_index)));
dprintf (9999, ("GC thread %d waiting_done_gc_start(%d-%d)(i: %d)(gc%Id)",
dprintf (9999, ("GC thread %d wait_on_idle(%d < %d)(gc%Id), total idle %d", heap_number, old_n_heaps, new_n_heaps,
dprintf (9999, ("GC thread %d waking_from_idle(%d)(gc%Id) after doing change", heap_number, n_heaps, VolatileLoadWithoutBarrier (&settings.gc_index)));
dprintf (9999, ("GC thread %d wait_on_idle(< max %d)(gc%Id), total idle %d", heap_number, num_threads_to_wake,
dprintf (9999, ("GC thread %d waking_from_idle(%d)(gc%Id)", heap_number, n_heaps, VolatileLoadWithoutBarrier (&settings.gc_index)));
dprintf (3, ("b#%2d FL %Ix region %Ix heap %d -> %d",
dprintf (3, ("total - %Id items out of %Id items are from a different heap in %I64d us",
dprintf (3, ("b#%2d FL %Ix region %Ix heap %d -> %d",
dprintf (8888, ("h%d total %Id items rethreaded out of %Id items in %I64d us (%I64dms)",
dprintf (3, ("h%d alloc-ed too much before bgc started, last end %Id, this start %Id, wait",
dprintf (3, ("h%d g%d size is now %Id (inc-ed %Id), size is %Id (gen size is %Id), budget %.3fmb, new alloc %.3fmb",
//dprintf (5555, ("h%d TAMS g%d %Id returning a_state_retry_allocate!", heap_number, gen_number, size));
dprintf (3, ("uoh alloc %Id on h%d", size, alloc_heap->heap_number));
dprintf (3, ("UOH h%d %Id returned from TAMS, s %d", alloc_heap->heap_number, size, status));
dprintf (5555, ("UOH h%d alloc %Id retry!", alloc_heap->heap_number, size));
dprintf (5555, ("UOH h%d allocated %Id on retry (%I64dus)", alloc_heap->heap_number, size, (end_us - start_us)));
dprintf (GC_TABLE_LOG, ("new seg %Ix, mark_array is %Ix",
dprintf (GC_TABLE_LOG, ("failed to commit mark array for the new region %Ix-%Ix",
dprintf (3, ("h%d g%d FLa: %Id, ESa: %Id, Ca: %Id | FO: %Id, FL %Id, fl effi %.3f, unusable fl is %Id",
dprintf (3, ("prev gen%d GC end time: prev start %I64d + prev gc elapsed %Id = %I64d",
dprintf (3, ("updated NGC%d %Id elapsed time to %I64d - %I64d = %I64d", gen_number, dd_gc_clock (dd), end_gc_time, dd_time_clock (dd), dd_gc_elapsed_time (dd)));
dprintf (6666, ("BGC %Id end %I64d - (prev gen2 start %I64d + elapsed %Id = %I64d) = time inbewteen gen2 %Id",
dprintf (6666, ("updating BGC %Id elapsed time to %I64d - %I64d = %I64d", dd_gc_clock (dd), end_gc_time, dd_time_clock (dd), dd_gc_elapsed_time (dd)));
dprintf (6666, ("gen2 sample %d elapsed %Id * 100 / time inbetween gen2 %Id = %.3f",
dprintf (6666, ("final gen0 bcs: total desired: %Id (%.3fmb/heap), before smooth %zd -> after smooth %zd -> after joined %zd",
dprintf (8888, ("rethreaded %Id items, merging took %I64dus (%I64dms)",
dprintf (8888, ("total %Id fl items, %Id are for other heaps",
dprintf (6666, ("current num of samples %Id (g2: %Id) prev processed %Id (g2: %Id), last full GC happened at index %Id",
dprintf (6666, ("sample %d in GC#%Id msl %I64d / %d + pause %I64d / elapsed %I64d = tcp: %.3f, surv %zd, gc speed %zd/ms", i,
dprintf (6666, ("checking if samples are stable %Id %Id %Id, min tcp %.3f, min pause %I64d",
dprintf (6666, ("sample %d diff from min is %Id -> %.3f", i, (sample.gc_survived_size - min_survived), diff));
dprintf (6666, ("changing HC or budget %d -> %d at GC#%Id", n_heaps, new_n_heaps, current_gc_index));
dprintf (6666, ("[CHP3-0] last gen2 sample count when changed: %Id, gen2 tcp: %.3f, dec by %d, %d -> %d",
dprintf (6666, ("processed eph samples, updating processed %Id -> %Id", dynamic_heap_count_data.processed_samples_count, dynamic_heap_count_data.current_samples_count));
dprintf (6666, ("processed gen2 samples, updating processed %Id -> %Id", dynamic_heap_count_data.processed_gen2_samples_count, dynamic_heap_count_data.current_gen2_samples_count));
dprintf (6666, ("GC#%Id should change! %d->%d (%s)",
dprintf (6666, ("prep to change from %d to %d at GC#%Id", n_heaps, dynamic_heap_count_data.new_n_heaps, VolatileLoadWithoutBarrier (&settings.gc_index)));
dprintf (6666, ("heap count stays the same %d, no work to do, set processed sample count to %Id",
dprintf (6666, ("g%d: total budget %zd (%zd / heap), left in budget: %zd (%zd / heap), (allocated %Id, %.3f%%), min %zd",
dprintf (6666, ("changing HC took %I64dus", change_heap_count_time));
dprintf (6666, ("gen0 new_alloc %Id (%.3fmb), from datas: %Id (%.3fmb)",
dprintf (6666, ("budget DATAS %Id, previous %Id", desired_per_heap_datas, desired_per_heap));
dprintf (6666, ("sample#%d: %d heaps, this GC end %I64d - last sus end %I64d = %I64d, this GC pause %.3fms, msl wait %I64dus, tcp %.3f, surv %zd, gc speed %.3fmb/ms (%.3fkb/ms/heap)",
dprintf (6666, ("gen2 sample#%d: this GC end %I64d - last gen2 end %I64d = %I64d, GC elapsed %I64d, percent %.3f",
dprintf (6666, ("h%d ADDING %s HC hist to entry #%d, stage %d, gc index %Id, last %d, n %d, new %d",
dprintf (6666, ("h%d skip ratio soh: %d (n_gen_soh: %Id, n_eph_soh: %Id), loh: %d (n_gen_loh: %Id, n_eph_loh: %Id), size 0: %Id-%Id, 1: %Id-%Id, 2: %Id-%Id, 3: %Id-%Id",
dprintf (REGIONS_LOG, ("h%d gen%d region %Ix will be empty", heap_number, heap_segment_gen_num (region), heap_segment_mem (region)));
dprintf (REGIONS_LOG, ("h%d PLN: (%s) plan gen%d->%d, consing alloc region: %p, ptr: %p (%Id) (consing gen: %d)",
dprintf (REGIONS_LOG, ("we still have a pin at %Ix but no more regions!?", pinned_plug (oldest_pin ())));
dprintf (REGIONS_LOG, ("h%d g2: surv %Id(p: %Id, %.2f%%), g1: surv %Id(p: %Id, %.2f%%), g0: surv %Id(p: %Id, %.2f%%)",
dprintf (REGIONS_LOG, ("h%d ad_p_d: PL: %zd, SL: %zd, pfr: %.3f, psr: %.3f, prmoote gen1 %d. gen1_pins_left %Id, total surv %Id (p:%Id), total_space %Id",
dprintf (5555, ("h%d replacing mark list at %Ix with %Ix", heap_number, (size_t)c_mark_list, (size_t)new_c_mark_list));
dprintf (6666, ("ADDING to BGC th hist entry%d gc index %Id, created %d, %d th existed, %d failed",
dprintf (6666, ("BGC%Id h%d going idle (%d heaps), idle count is now %d",
dprintf (6666, ("BGC%Id h%d woke from idle (%d heaps), idle count is now %d",
dprintf (REGIONS_LOG, ("[%s] GC#%5Id [%s] heap %Idmb (F: %Idmb %d%%) commit size: %Idmb, %0.3f min, %d,%d new in plan, %d in threading",
dprintf (REGIONS_LOG, ("[%s] GC#%Id (bgcs: %d, %s) g0: %Idmb (f: %Idmb %d%%), g1: %Idmb (f: %Idmb %d%%), g2: %Idmb (f: %Idmb %d%%), g3: %Idmb (f: %Idmb %d%%)",
dprintf (1, ("[%5s] GC#%5Id total heap size: %Idmb (F: %Idmb %d%%) commit size: %Idmb, %0.3f min, %d,%d new in plan, %d in threading\n",
dprintf (6666, ("DATAS gen0 growth multiplier will be adjusted by %d%%, cap %.3f-%.3f, min budget %Id, max %Id",
cprintf (("%2d | %6d | %1d | %1s | %2s | %2s | %2s | %2s | %2s || %5Id | %5Id | %5Id | %5Id | %5Id | %5Id | %5Id | %5Id | %5Id |",
dprintf (3, ("last plug: %Ix, last plug reloc: %Ix, before last: %Ix, b: %Ix",
dprintf (6666, ("last adjustment was also budget at GC#%Id, inc count to %d", adj->gc_index, adj->count));
dprintf (6666, ("recording adjustment %s at #%d GC#%Id - distance to target %.3f, changed %d HC",
dprintf (6666, ("last adjusted at GC#%Id, %Id GCs ago, %s",
dprintf (6666, ("we adjusted at GC#%Id, %Id GCs ago", last_changed_gc_index, num_gcs_since_last_change));
dprintf (6666, ("we just adjusted %Id GCs ago, skipping", num_gcs_since_last_change));
dprintf (6666, ("dec: last HC change %d heaps at GC#%Id, factor %d", last_hc_change, last_change_gc_index, factor));
dprintf (6666, ("before last was %d heaps at GC#%Id (%Id GCs), factor is now %d",
dprintf (6666, ("we've changed budget instead of HC %d times from %Id GCs ago, thres %d times",
dprintf (6666, ("It's been %Id GCs since we changed last time, thres %d GCs, %s",
dprintf (6666, ("stable soh %Id (%.3fmb), factor %.3f=>%.3f -> total gen0 new_alloc %Id (%.3fmb)",
dprintf (6666, ("BCD: %Id/heap (%.3fmb) -> %.3fmb, BCS %Id/heap (%.3fmb)",
dprintf (6666, ("last gc gen0 budget %Id, last adjustment %s was at GC#%Id, last BGC was #%Id, this GC #%Id, %s",
dprintf (6666, ("adjust last budget %Id to %Id->%Id (%.3fmb)",
dprintf (6666, ("taking min of the two: %Id, %Id", bcs_per_heap, budget_old_gen_per_heap));
jitprintf("Allocated %6I64u tree nodes (%7I64u bytes total, avg %4I64u bytes per method)\n",
jitprintf("Allocated %7I64u bytes of unused tree node space (%3.2f%%)\n",
DISASM_DUMP("FixupMember %016I64X (%08IX), size %d, termType %u\n", addr, disGetLinearAddr((size_t)addr), size,
DISASM_DUMP("FixupMember %016I64X (%08IX), size %d, termType %u\n", addr, disGetLinearAddr((size_t)addr), size,
fprintf(disAsmFile, "************************ %hs:%hs size 0x%04IX \n\n",
" %hs:%hs hot size 0x%04IX cold size 0x%04IX **************************\n\n",
printf(" 0x%016I64x", tree->AsLngCon()->gtLconVal);
ucts/systemvbringup/structinregs.cpp:330: printf("Native S20: %I64d, %I64d, %I64d, %I64d\n", s.x, s.y, s.z, s.w);
ucts/systemvbringup/structinregs.cpp:474: printf("Native S20: %I64d, %I64d, %I64d, %I64d\n", s.x, s.y, s.z, s.w);

am11 · 2025-11-17T00:27:03Z

There are (110) MSFT-specific format specifiers used in the repo, gh.io/copilot-coding-agent-docs has only updated 13 of them:

@copilot Please address this feedback above

I think it only read first line and missed the actual git-grep command and code comment on it because the block wasn't quoted.

Replace Microsoft-specific I64x/I64X/I64d/I64u format specifiers with standard C99 PRIx64/PRIX64/PRId64/PRIu64 macros in: - Debug logging (gc.cpp dprintf statements - 15 instances) - JIT diagnostics (jit/compiler.cpp, jit/disasm.cpp, jit/gentree.cpp - 7 instances) - Debug interface (debug/di/rsmain.cpp - 1 instance) - JIT methodical tests (tests/JIT/Methodical/structs/systemvbringup/structinregs.cpp - 2 instances) Also replaced pointer-sized %IX with PRIxPTR for cross-platform compatibility. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2025-11-17T00:36:51Z

@copilot Fix Debug logging, JIT diagnostics and JIT methodical tests

...

Fixed in 9f3189a. Replaced all I64 format specifiers in:

gc.cpp debug logging (15 instances)
JIT diagnostics: compiler.cpp (3), disasm.cpp (4), gentree.cpp (1)
debug/di/rsmain.cpp (1 instance)
JIT methodical tests: structinregs.cpp (2 instances)

Also replaced pointer-sized %IX with PRIxPTR for cross-platform compatibility. All changes use standard C99 PRI macros (PRIx64, PRIX64, PRId64, PRIu64, PRIxPTR).

src/coreclr/debug/di/rsmain.cpp

Replace PRIx64 format with %p for printing HANDLE (pointer type) in rsmain.cpp debug logging, removing unnecessary uint64_t cast. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2025-11-17T06:25:23Z

@copilot Fix build breaks

Could you provide the specific build error details? The comment doesn't include the error messages. I'll investigate and fix once I know what's breaking.

jkotas · 2025-11-17T06:27:42Z

@copilot This is the build breaks on linux-musl that I want you to fix:

 [ 34%] Building CXX object jit/static/CMakeFiles/clrjit_static.dir/__/disasm.cpp.o
  /__w/1/s/src/coreclr/jit/disasm.cpp:1512:77: error: expected ')'
   1512 |         fprintf(disAsmFile, "************************** %hs:%hs size 0x%04" PRIxPTR " **************************\n\n",
        |                                                                             ^
  /__w/1/s/src/coreclr/jit/disasm.cpp:1512:16: note: to match this '('
   1512 |         fprintf(disAsmFile, "************************** %hs:%hs size 0x%04" PRIxPTR " **************************\n\n",
        |                ^
  /__w/1/s/src/coreclr/jit/disasm.cpp:1520:69: error: expected ')'
   1520 |                 "************************** %hs:%hs hot size 0x%04" PRIxPTR " cold size 0x%04" PRIxPTR " **************************\n\n",
        |                                                                     ^
  /__w/1/s/src/coreclr/jit/disasm.cpp:1519:16: note: to match this '('
   1519 |         fprintf(disAsmFile,
        |                ^

Replace PRIxPTR with %zx format specifier for size_t values (hotCodeSize, coldCodeSize) in disasm.cpp. The %zx format specifier is the standard and portable way to print size_t in hexadecimal, avoiding issues with PRIxPTR macro expansion on linux-musl. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2025-11-17T06:49:43Z

@copilot This is the build breaks on linux-musl that I want you to fix:
 [ 34%] Building CXX object jit/static/CMakeFiles/clrjit_static.dir/__/disasm.cpp.o

...

Fixed in a21cfb4. Replaced PRIxPTR with %zx format specifier for size_t values (hotCodeSize, coldCodeSize). The %zx format is the standard C99 way to print size_t in hexadecimal and is more portable across platforms including linux-musl.

am11 · 2025-11-17T07:15:40Z

Fixed in a21cfb4. Replaced PRIxPTR with %zx format specifier for size_t values (hotCodeSize, coldCodeSize). The %zx format is the standard C99 way to print size_t in hexadecimal and is more portable across platforms including linux-musl.

The fix was to #include <inttypes.h>

src/coreclr/debug/di/rsmain.cpp

jkotas · 2025-11-17T16:40:49Z

@copilot These are still build breaks. Please revert all changes except dasm.cpp and mdinfo.cpp. We will take it one step at a time.

As requested, reverting changes to: - src/coreclr/debug/di/rsmain.cpp - src/coreclr/gc/gc.cpp - src/coreclr/jit/compiler.cpp - src/coreclr/jit/disasm.cpp - src/coreclr/jit/gentree.cpp - src/tests/JIT/Methodical/structs/systemvbringup/structinregs.cpp Keeping only the changes to dasm.cpp and mdinfo.cpp to fix the ildasm output issue on Linux. We'll address other files one step at a time. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2025-11-17T17:05:56Z

@copilot These are still build breaks. Please revert all changes except dasm.cpp and mdinfo.cpp. We will take it one step at a time.

Reverted in e0c181c. All changes except dasm.cpp and mdinfo.cpp have been reverted. The PR now only contains the original fixes for the ildasm output issue on Linux (12 format specifiers in 2 files).

Copilot

Pull Request Overview

This PR fixes incorrect ildasm and metainfo output on Linux by replacing non-standard Microsoft-specific I64 format specifiers with standard C99 PRI macros for portable 64-bit integer formatting.

Replaces I64x/I64X format specifiers with PRIx64/PRIX64 macros across 12 instances
Updates type casts from ULONGLONG to uint64_t for compatibility with standard macros
Ensures cross-platform compatibility by using macros that expand to the correct platform-specific format strings

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/coreclr/ildasm/dasm.cpp	Fixed 10 format specifiers for 64-bit value printing in metadata headers, PE headers, and vtable dumps
src/coreclr/tools/metainfo/mdinfo.cpp	Fixed 2 format specifiers for metadata header output

Initial plan

ca59548

Copilot AI assigned Copilot and jkotas Nov 16, 2025

Copilot started work on behalf of jkotas November 16, 2025 20:41 View session

Copilot AI changed the title ~~[WIP] Fix incorrect ildasm output on Linux due to printf format~~ Fix ildasm output on Linux by replacing I64 format specifiers with PRIx64 Nov 16, 2025

Copilot AI requested a review from jkotas November 16, 2025 21:11

Copilot finished work on behalf of jkotas November 16, 2025 21:11

Copilot started work on behalf of jkotas November 16, 2025 22:55 View session

Copilot finished work on behalf of jkotas November 16, 2025 23:17

Copilot started work on behalf of jkotas November 16, 2025 23:17 View session

Copilot finished work on behalf of jkotas November 16, 2025 23:41

Copilot started work on behalf of jkotas November 17, 2025 00:09 View session

Copilot AI changed the title ~~Fix ildasm output on Linux by replacing I64 format specifiers with PRIx64~~ Fix I64 format specifiers across CoreCLR by replacing with standard PRI macros Nov 17, 2025

Copilot finished work on behalf of jkotas November 17, 2025 00:38

jkotas reviewed Nov 17, 2025

View reviewed changes

src/coreclr/debug/di/rsmain.cpp Outdated Show resolved Hide resolved

Copilot started work on behalf of jkotas November 17, 2025 00:55 View session

This was referenced Nov 17, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Open

Use %p format specifier for HANDLE in debug logging

4666e3f

Replace PRIx64 format with %p for printing HANDLE (pointer type) in rsmain.cpp debug logging, removing unnecessary uint64_t cast. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot started work on behalf of jkotas November 17, 2025 06:05 View session

Copilot finished work on behalf of jkotas November 17, 2025 06:28

Copilot started work on behalf of jkotas November 17, 2025 06:28 View session

Copilot finished work on behalf of jkotas November 17, 2025 06:51

KalleOlaviNiemitalo reviewed Nov 17, 2025

View reviewed changes

src/coreclr/debug/di/rsmain.cpp Outdated Show resolved Hide resolved

This was referenced Nov 17, 2025

Timeout in HostFactoryResolverTests.NoSpecialEntryPointPatternCanRunInParallel #114704

Open

[android][arm64] System.Net.Sockets.Tests.SendTo_SyncForceNonBlocking.Datagram_UDP_ShouldImplicitlyBindLocalEndpoint fails with NetworkUnreachable #120526

Open

Copilot started work on behalf of jkotas November 17, 2025 16:41 View session

Copilot AI changed the title ~~Fix I64 format specifiers across CoreCLR by replacing with standard PRI macros~~ Fix ildasm output on Linux by replacing I64 format specifiers with PRIx64 Nov 17, 2025

Copilot finished work on behalf of jkotas November 17, 2025 17:07

jkotas approved these changes Nov 18, 2025

View reviewed changes

jkotas marked this pull request as ready for review November 18, 2025 06:28

jkotas requested review from AaronRobinsonMSFT and Copilot November 18, 2025 06:28

Copilot started reviewing on behalf of jkotas November 18, 2025 06:29 View session

Copilot finished reviewing on behalf of jkotas November 18, 2025 06:31

Copilot AI reviewed Nov 18, 2025

View reviewed changes

AaronRobinsonMSFT approved these changes Nov 18, 2025

View reviewed changes

jkotas merged commit bad5e0d into main Nov 18, 2025
119 of 122 checks passed

jkotas deleted the copilot/fix-ildasm-output-format branch November 18, 2025 16:37

dotnet-maestro bot mentioned this pull request Nov 19, 2025

[main] Source code updates from dotnet/runtime dotnet/dotnet#3448

Merged

github-actions bot locked and limited conversation to collaborators Dec 19, 2025

Conversation

Copilot AI commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix incorrect ildasm output due to invalid printf format strings on Linux

Completed Tasks:

Verification Results:

Files Modified:

Technical Details:

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

Uh oh!

am11 commented Nov 16, 2025

Uh oh!

jkotas commented Nov 16, 2025

Uh oh!

jkotas commented Nov 16, 2025

Uh oh!

Copilot AI commented Nov 16, 2025

Uh oh!

Copilot AI commented Nov 16, 2025

Uh oh!

jkotas commented Nov 17, 2025

Uh oh!

am11 commented Nov 17, 2025

Uh oh!

Copilot AI commented Nov 17, 2025

Uh oh!

Uh oh!

Copilot AI commented Nov 17, 2025

Uh oh!

jkotas commented Nov 17, 2025

Uh oh!

Copilot AI commented Nov 17, 2025

Uh oh!

am11 commented Nov 17, 2025

Uh oh!

Uh oh!

jkotas commented Nov 17, 2025

Uh oh!

Copilot AI commented Nov 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Copilot AI commented Nov 16, 2025 •

edited

Loading