Skip to content

Delete InlineArrays.cs and replace types #121943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2025
Merged

Delete InlineArrays.cs and replace types #121943

merged 2 commits into from
Nov 25, 2025

Conversation

@itsBuggingMe
Copy link
Contributor

@itsBuggingMe itsBuggingMe commented Nov 24, 2025

Helps reduce the total number of types by replacing ThreeObjects, TwoObjects, and EightObjects with the existing InlineArrayX<T> types.

@itsBuggingMe
Delete InlineArrays.cs and replace types
37e46b9 
Deleted InlineArrays.cs and replaced `TwoObjects` and `ThreeObjects` with collection expressions. `EightObjects` was replaced with `InlineArray8<object?>`.
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 24, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 24, 2025
@itsBuggingMe
Copy link
Contributor Author

itsBuggingMe commented Nov 24, 2025

@dotnet-policy-service agree

@build-analysis build-analysis bot mentioned this pull request Nov 25, 2025
Open
jkotas
jkotas approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 3ac1925 into dotnet:main Nov 25, 2025
142 checks passed
@itsBuggingMe itsBuggingMe deleted the remove-object-inlinearray branch November 25, 2025 15:51
@dotnet-maestro dotnet-maestro bot mentioned this pull request Nov 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itsBuggingMe @jkotas