Use CorSigUncompressCallingConv to uncompress calling conventions in PrettyPrintSignature
#122177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `PrettyPrintSignature` We were using `CorSigUncompressData` on the calling convention byte, but this is not stored as a normal compressed integer. It happened to work because compressed integers are specified by having their upper bit set, and metadata signatures never have that bit set. However, for some internal cases we repurpose that bit (specifically to specify that a signature has a generic context parameter).
github-actions
bot
added
the
needs-area-label
jakobbotsch
added
area-VM-coreclr
and removed
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where calling convention bytes in signatures were being incorrectly decompressed using CorSigUncompressData instead of the proper CorSigUncompressCallingConv function. The issue is corrected in the PrettyPrintSignature function by replacing two instances where the wrong decompression function was used.
Key Changes:
- Replaced
CorSigUncompressDatawithCorSigUncompressCallingConvfor reading calling convention bytes - Calling conventions are single bytes, not compressed integers, so the specialized function is required
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
approved these changes
Dec 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
CorSigUncompressDataon the calling convention byte, but this is not stored as a normal compressed integer. It happened to work because compressed integers are specified by having their upper bit set, and metadata signatures never have that bit set in their calling convention. However, for some internal cases we repurpose that bit (specifically to specify that a signature has a generic context parameter).Fix #122050