JIT: Disable flag optimization on arm32 again #122215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm32 does not set the right flags for these bitwise and operations, so it cannot be enabled.
github-actions
bot
added
the
area-CodeGen-coreclr
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo (fixes innerloop) |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables flag optimization for GT_AND and GT_AND_NOT operations on ARM32 architecture, which was incorrectly enabled in a previous change (#121380). The issue was that ARM32 does not set the correct flags for these operations, causing test failures referenced in #122185.
- Restricts
SupportsSettingFlagsAsCompareToZero()to ARM64 only (previously both ARM32 and ARM64) - Refactors
SupportsSettingZeroFlag()to callSupportsSettingFlagsAsCompareToZero()first, eliminating duplicate code - Properly fixes the root cause of test failures on ARM32
3 tasks
filipnavara
approved these changes
Dec 5, 2025
EgorBo
approved these changes
Dec 5, 2025
Member
Author
|
/ba-g Deadletter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm32 does not set the right flags for these operations, so it cannot be enabled.
I enabled this in #121380, and these tests did fail there too, but I mistakenly thought the failure was preexisting and the same as #121659.
Also do a small refactoring while I'm here, to make use of
SupportsSettingFlagsAsCompareToZerofromSupportsSettingZeroFlag.Fix #122185