-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix Mono Debugger 200ms Pause (Issue #122344) #122449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @thaystg, @dotnet/dotnet-diag |
6cfe035 to
3ef1b3c
Compare
|
@csa7mdm thanks for the submission! We'll give it a review and test to see how it helps. |
b49ca0e to
ce20820
Compare
51702d4 to
28edd58
Compare
- Move TCP_NODELAY to start of transport_handshake to ensure immediate handshake transmission. - Enable TCP_QUICKACK in socket_transport_send to prevent delayed ACKs during event transmission.
1ab3f01 to
dd12ccc
Compare
|
@csa7mdm thanks again for your contribution. I shared in #122344 (comment) that we were able to fix the problem on the VS / VSCode side and a fix is being worked through. Since no runtime change is required to make things better, I'm going to close this PR. |
Fixes #122344
This PR eliminates the ~200ms pause observed during exception handling when the VS debugger is attached to Mono (e.g. Android/MAUI).
Changes:
Verification:
Verified code logic correctness. This change strictly affects the transport layer.