-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0-staging] Use explicit versions for MSBuild properties #122502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Use explicit versions for MSBuild properties #122502
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
Some failures in browser-wasm tests are unrelated. Also failing in other PRs, i.e. #122199 with the same errors. Likely due to a warning in |
|
@hoyosjs @jkoritzinsky who can help merge this? I don't have permissions to merge on red. Test failures are unrelated and repro in other PRs. |
|
/ba-g failed during the macos13 brownout. |
2064f12
into
dotnet:release/8.0-staging
This PR reapplies the change in
Versions.propsfrom #121307Somehow, that change was lost in the past month.
I am also adding a comment to ensure someone doesn't revert the intentional change to use explicit versions for all 4 MSBuild properties and use a reference to the "main" property.
Notes
This is an infra change as this change produces no differences in the runtime build.
There are also no differences in source-build as we currently have a patch that sets these properties to explicit versions: https://github.com/dotnet/installer/blob/release/8.0.1xx/src/SourceBuild/patches/runtime/0002-Update-MSBuild-dependencies.patch
With this fix, we will be able to remove the source-build patch.