[browser][coreCLR] detect browser features and fail fast #122799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds browser feature detection to fail fast when the JavaScript engine doesn't support required WebAssembly features (exception handling and SIMD). This addresses a TODO item in the codebase about detecting missing WASM features early in the startup process.
- Introduces a new
validateWasmFeatures()function that checks for WASM exception handling and SIMD support - Integrates feature validation into the runtime initialization flow to fail early with clear error messages
- Uses the
wasm-feature-detectnpm package to perform browser capability detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/corehost/browserhost/loader/run.ts | Imports and calls the new validateWasmFeatures() function during runtime creation, after config is loaded but before any resources are processed |
| src/native/corehost/browserhost/loader/bootstrap.ts | Implements the validateWasmFeatures() function that checks for WASM exception handling and SIMD support using the wasm-feature-detect library |
ilonatommy
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateWasmFeatures()which makes sure that the JS Engine supports WASM EH and SIMD