Skip to content

[RyuJIT Wasm] Memops on wasm are not containable #122900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[RyuJIT Wasm] Memops on wasm are not containable #122900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/coreclr/jit/regallocwasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ void WasmRegAlloc::dumpLsraStatsSummary(FILE* file)

bool WasmRegAlloc::isContainableMemoryOp(GenTree* node)
Copy link
Contributor

@SingleAccretion SingleAccretion Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the call stack that hits this? We shouldn't be trying to contain any memory ops, not yet. Though we will eventually do this for casts (to emit things like CAST<long>(IND<int>) as one load).

If this is hit from a caller that "makes sense", the right implementation would be to move what is now in lsrabuild.cpp to regalloc.cpp.

Copy link
Member Author

@kg kg Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run a superpmi replay on x86 right now it gets hit ~40 times, see #122627 - I reproduced it locally too

{
NYI_WASM("isContainableMemoryOp");
return false;
}

Expand Down
Loading