[Wasm RyuJIT] Add some missing types to ins_Load and ins_Store #122994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes assertions in the Wasm RyuJIT compiler by adding missing type cases for TYP_REF and TYP_BYREF in the instruction selection functions. These reference and byref types were causing asserts during superpmi replays because they weren't explicitly handled in the WASM-specific switch statements.
Key changes:
- Added TYP_REF and TYP_BYREF cases to ins_Load function for WASM target
- Added TYP_REF and TYP_BYREF cases to ins_Store function for WASM target
- Both cases fall through to TYP_INT, mapping to i32 instructions (appropriate for WASM32's 4-byte pointers)
- Included TODO comments noting future 64-bit support requirements
This was referenced Jan 8, 2026
Member
Author
|
cc @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Jan 8, 2026
This was referenced Jan 8, 2026
Open
SingleAccretion
approved these changes
Jan 8, 2026
Member
Author
|
/ba-g known iOS lane flakes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a bunch of asserts here when doing superpmi replays, from TYP_REF ending up in here.