JIT: Fix build after two conflicting changes #123128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a build break caused by conflicting changes to the impGetNodeAddr function signature and a call site in impImportAndPushBoxForNullable.
Changes:
- Updates the
impGetNodeAddrcall to include the newallowedMustPreserveIndirFlagsparameter with valueGTF_IND_INITCLASS - Adds a comment explaining that boxing allows the "initclass" flag but not volatile/unaligned flags
EgorBo
approved these changes
Jan 13, 2026
Member
Author
|
/ba-g Early merge to fix CI build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122381 changed the signature of a function that had another use introduced by #122167