[browser] Add explicit runtime flavor to perf pipeline#123181
Merged
Conversation
maraf
added
arch-wasm
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit /p:RuntimeFlavor=Mono parameter to the browser/WASM performance pipeline's artifact preparation step. This aligns the performance pipeline with other browser/WASM build configurations that already specify the runtime flavor explicitly.
Changes:
- Added
/p:RuntimeFlavor=Monoto the build command in the WASM performance artifact preparation template
lewing
approved these changes
Jan 14, 2026
lewing
added a commit
that referenced
this pull request
Feb 11, 2026
## Problem After UseMonoRuntime was removed from in-tree wasm props (PR #121789 by @maraf), browser-wasm test restores fail with NU1102 (package not found). The `RestorePackage` target in `build.proj` runs `dotnet restore` for test dependency projects. These projects use `Microsoft.NET.Sdk` (not the WebAssembly SDK), so `UseMonoRuntime` is not set. Without it, the newer SDK tries to download `Microsoft.NETCore.App.Runtime.browser-wasm` (CoreCLR pattern) or `Microsoft.NETCore.App.Runtime.Mono.browser-wasm` from NuGet — packages that don't exist for .NET 11. The test restore doesn't need runtime or targeting packs from NuGet — those come from the local build and are wired up during the test build step. However, `EnableRuntimePackDownload=false` and `EnableTargetingPackDownload=false` were only passed conditionally (when `UseLocalAppHostPack=true`), and browser-wasm sets `UseLocalAppHostPack=false`. ## Fix Unconditionally pass `-p:EnableRuntimePackDownload=false -p:EnableTargetingPackDownload=false` to the test dependency restore command. This fixes both Mono and CoreCLR browser-wasm configurations since neither needs pack downloads during restore. ## Context - Root cause PR: #121789 (Remove duplicated UseMonoRuntime=true from SDK) - Follow-up pattern: #123181 (Added RuntimeFlavor=Mono to perf pipeline) - Affected codeflow PR: #124232 cc @maraf @akoeplinger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression from #122495. I have updated runtime.yml pipeline, but missed performance.
runtime/eng/pipelines/common/templates/browser-wasm-build-tests.yml
Line 115 in 5671ed3