Interpreter - disable libraries tests using marshalled calli #123213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marshalled calli is not supported with the interpreter
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables three library tests that use marshalled calli instructions when running under the CoreCLR interpreter. The changes add ActiveIssue attributes to skip tests that are not supported with interpreter mode, and includes a minor whitespace fix.
Changes:
- Added ActiveIssue attributes to three test methods that test marshalled calli functionality
- Fixed indentation in one test method
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/libraries/System.Reflection.Emit/tests/PersistedAssemblyBuilder/AssemblySaveILGeneratorTests.cs | Added ActiveIssue attribute to EmitCalliNonBlittable test and fixed indentation |
| src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs | Added ActiveIssue attributes to TestEmitCalliNonBlittable and TestDynamicMethodEmitCalliNonBlittable tests |
src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs
Outdated
Show resolved
Hide resolved
...raries/System.Reflection.Emit/tests/PersistedAssemblyBuilder/AssemblySaveILGeneratorTests.cs
Outdated
Show resolved
Hide resolved
davidwrighton
approved these changes
Jan 16, 2026
The interpreter detection was correct, but the way copilot suggested feels better for the libraries tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshalled calli is not supported with the interpreter