Localization: Fix "on" string translation in ExtendedPropertyDescriptor #123315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel |
- Replaced hardcoded "on" string with SR.MetaExtenderName in ExtendedPropertyDescriptor. - Removed unused ItemGroup and Content inclusion for testFileToReload.json that was causing Wasm build failures. - Optimized logic with string.IsNullOrEmpty for better maintainability.
….csproj Description: Restoring the csproj file to its original state to resolve WASM and library test failures, keeping only the localization fix in ExtendedPropertyDescriptor.cs.
This was referenced Jan 18, 2026
This was referenced Jan 21, 2026
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108422
Description
This PR addresses the hardcoded "on" string issue in
ExtendedPropertyDescriptorby moving it to the centralized resource file (Strings.resx). This change is essential for supporting proper localization (L10N) across different languages where the word order or the preposition might differ.Changes
SR.MetaExtenderNamein resources.SR.Formatfor safer and more localized formatting.string.IsNullOrEmptyfor better readability and slightly better performance..csprojthat were causing environment-specific build failures.Impact