Skip to content

Conversation

@gwr
Copy link
Contributor

@gwr gwr commented Jan 20, 2026

Fixes #123368

Copilot AI review requested due to automatic review settings January 20, 2026 15:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a platform-specific workaround for a memset namespace issue on illumos/Solaris systems (TARGET_SUNOS). The change addresses issue #17832 from illumos.org by explicitly using std::memset on affected platforms while maintaining the existing behavior on other platforms.

Changes:

  • Added conditional compilation for TARGET_SUNOS to handle memset differently
  • Explicitly references std::memset on illumos/Solaris to work around namespace issues

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 20, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas changed the title Work-around #123368 memset namespace issue Work-around memset namespace issue on SunOS Jan 20, 2026
@jkotas jkotas enabled auto-merge (squash) January 20, 2026 15:11
auto-merge was automatically disabled January 20, 2026 17:45

Head branch was pushed to by a user without write access

@gwr
Copy link
Contributor Author

gwr commented Jan 20, 2026

Fixed commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

src/coreclr/vm/qcallentrypoints.cpp:320 memset problem

2 participants