Skip to content

Implement IDisposable in BlazorWebWasmLogClient #123392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oroztocil merged 2 commits into from
Jan 20, 2026
Merged

Implement IDisposable in BlazorWebWasmLogClient #123392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a6546
Initial plan
Copilot Jan 20, 2026
5ab7fac
Implement IDisposable in BlazorWebWasmLogClient
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mono/wasm/Wasm.Build.Tests/Blazor/AssetCachingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public async Task BlazorApp_BasedOnFingerprinting_LoadsWasmAssetsFromCache()
await page.GotoAsync($"{baseUrl}counter");
await counterLoaded.Task;

var requestLogClient = new BlazorWebWasmLogClient(baseUrl);
using var requestLogClient = new BlazorWebWasmLogClient(baseUrl);
var firstLoadRequestLogs = await requestLogClient.GetRequestLogsAsync();
var firstLoadWasmRequests = firstLoadRequestLogs.Where(log => log.Path.EndsWith(".wasm"));

Expand Down
7 changes: 6 additions & 1 deletion src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWebWasmLogClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Wasm.Build.Tests.Blazor;
/// <summary>
/// Client for interacting with the request log API exposed by the BlazorWebWasm test server app.
/// </summary>
internal class BlazorWebWasmLogClient
internal class BlazorWebWasmLogClient : IDisposable
{
private readonly HttpClient _httpClient;

Expand All @@ -36,4 +36,9 @@ public async Task ClearRequestLogsAsync()
var response = await _httpClient.DeleteAsync("request-logs");
response.EnsureSuccessStatusCode();
}

public void Dispose()
{
_httpClient?.Dispose();
}
}