Make order of generated logger items stable.#123428
Merged
cincuranet merged 8 commits intodotnet:mainfrom Jan 23, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses non-deterministic code generation in the Logger Message Generator by sorting logger classes before emitting them. The change ensures that generated code output is stable across different builds.
Changes:
- Modified the
Emitmethod to sort logger classes by namespace and then by name before generating code
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2026
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 21, 2026
Open
tarekgh
reviewed
Jan 21, 2026
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Jan 21, 2026
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
tarekgh
added
the
source-generator
Member
|
@cincuranet by the way, thanks for fixing this issue 😄 |
Contributor
Author
|
@tarekgh PTAL |
cincuranet
added a commit
to dotnet/extensions
that referenced
this pull request
Jan 22, 2026
Fall out from dotnet/runtime#123428 (comment).
tarekgh
reviewed
Jan 22, 2026
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
cincuranet
added a commit
to dotnet/extensions
that referenced
this pull request
Jan 23, 2026
rosebyte
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emits generated classes for logging ordered for stable/deterministic build output.
Fixes #119587.