Skip to content

Add test for custom attribute with generic enum array argument #123445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −0
Open

Add test for custom attribute with generic enum array argument #123445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/libraries/System.Runtime/tests/System.Reflection.Tests/CustomAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,5 +284,39 @@ public void SystemObject_GetCustomAttributes_InheritanceConsistency()
object[] attributesWithInherit = objectType.GetCustomAttributes(inherit: true);
Assert.Equal(attributesWithoutInherit.Length, attributesWithInherit.Length);
}

// Test for generic enum argument with array - related to https://github.com/dotnet/runtime/pull/123439
private class GenericEnumAttributeWithArray : Attribute
{
public GenericEnumAttributeWithArray(GenericClassForEnum<int[]>.E e) { }
}

private class GenericClassForEnum<T>
{
public enum E { }
}

[GenericEnumAttributeWithArray(default)]
private class ClassWithGenericEnumAttribute { }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123878", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))]
public void CustomAttributeCtor_WithGenericEnumArgument_DecodesCorrectly()
{
// This test ensures correct reflection behavior when loading a custom attribute
// whose constructor argument is a generic enum instance involving an array.
// This scenario was causing a crash in Mono (see https://github.com/dotnet/runtime/pull/123439)
var attr = typeof(ClassWithGenericEnumAttribute).CustomAttributes.Single(d => d.AttributeType == typeof(GenericEnumAttributeWithArray));
var arg = attr.ConstructorArguments.Single();

// Verify that we can successfully decode the attribute without crashing
Assert.Equal(typeof(CustomAttributeTypedArgument), arg.GetType());

// Verify the argument type is the expected generic enum type
Assert.Equal(typeof(GenericClassForEnum<int[]>.E), arg.ArgumentType);

// Verify the value is the default enum value (0)
Assert.Equal(0, Convert.ToInt32(arg.Value));
}
}
}
Loading