Add interp support for field addr via helper #123466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interpreter compiler was missing support for getting field address via helper call that is used in EnC scenarios. This change adds such support for both static and instance fields. It makes all System.Runtime.Loader.Tests libraries tests pass when running interpreted.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds interpreter support for accessing fields via helper calls, which is required for Edit and Continue (EnC) scenarios. The changes enable the interpreter to handle CORINFO_FIELD_STATIC_ADDR_HELPER and CORINFO_FIELD_INSTANCE_ADDR_HELPER field accessors, making System.Runtime.Loader.Tests libraries tests pass when running interpreted.
Changes:
- Added support for static field address via helper (
CORINFO_FIELD_STATIC_ADDR_HELPER) inEmitStaticFieldAddress - Added support for instance field address via helper (
CORINFO_FIELD_INSTANCE_ADDR_HELPER) in LDFLDA, LDFLD, and STFLD operations - All implementations correctly call the appropriate helper and perform indirection when needed for load/store operations
davidwrighton
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter compiler was missing support for getting field address via helper call that is used in EnC scenarios.
This change adds such support for both static and instance fields. It makes all System.Runtime.Loader.Tests libraries tests pass when running interpreted.