-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[browser][coreCLR] node and v8 CLI support for default browser runtime #123501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @agocke, @jeffschwMSFT, @elinor-fung |
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the idea. Thanks!
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
# Conflicts: # src/native/corehost/browserhost/loader/exit.ts
|
In short discussion with Maraf yesterday, he expressed that self-configuration V8 (and maybe NodeJS) use-case is moot. That's the methods It's fair to say that for R2R or linking any native C library we actually need WASM-SDK. My use-cases for that self-configuration from current directory are mostly about lowering the bar of exploration and adoption.
What do you think @maraf @radekdoulik @lewing @AaronRobinsonMSFT |
|
I introduced I made it to be For Mono it was I also changed the default @maraf please let's talk about this |
We had chance to discuss at length with @maraf this morning. TL;DR: the self-configuring CLI experience doesn't make much sense outside of simplest demo. Use WASM SDK!
I will close this PR, take the V8 polyfill and other useful bits of this PR and create another PR. |
This PR allows to use
dotnet.jsdirectly from runtime pack similar way asdotnet.exe runMotivation: V8 is a "naked" JS engine. We use it to run microbenchmarks.
The challenge with V8 is that doesn't give us the directory listing feature of the OS.
So we have to first create file
dotnet.assets.txtthat the V8 could read list of DLLs.Alternatively you can always use our WASM SDK, to create full application manifest (with all the DLLs and other config) and embed it directly into
dotnet.js.Or alternatively
import { dotnet } from './_framework/dotnet.js'as a library and use it's host builder API.Or alternatively even more stripped
corerun, that works only with NodeJSFixes #120208
Both A1) and A2)