[clr-interp] Cause compilation to be skipped when using function only used by tail-call helper #123508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used by tail-call helper
github-actions
bot
added
the
needs-area-label
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Member
Author
|
/azp run runtime-interpreter |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidwrighton
removed
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for skipping interpreter compilation when encountering the NextCallReturnAddress intrinsic that is not followed by a POP instruction. This intrinsic is used in tail-call helper functions which are currently only supported by the JIT, not the interpreter.
Changes:
- Introduces a new
SKIPCODEerror handling function that throwsCORJIT_SKIPPEDexception to skip compilation - Adds handling for
NI_System_StubHelpers_NextCallReturnAddressinEmitNamedIntrinsicCallto skip compilation when the intrinsic is not followed by POP
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/interpreter/failures.h | Added declaration for new SKIPCODE function |
| src/coreclr/interpreter/eeinterp.cpp | Implemented SKIPCODE function that throws CORJIT_SKIPPED exception |
| src/coreclr/interpreter/compiler.cpp | Added case handler for NextCallReturnAddress intrinsic to skip compilation when not followed by POP |
This was referenced Jan 27, 2026
Open
This was referenced Jan 30, 2026
Member
Author
|
/ba-g known infra issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NextCallReturnAddress intrinsic is only actually used in a case inside of the tail-call helper function, and in some of our interp modes we occasionally try to interpreter this tail-call helper. Instead of allowing that to happen, just skip the compilation.