Update MicrosoftCodeAnalysisVersion_LatestVS #123514
Open
+272
−641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match what is included in the SDK from global.json.
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Microsoft.CodeAnalysis (Roslyn) version to match what's referenced in the .NET SDK 10.0.1xx, and addresses code analysis warnings introduced by the newer Roslyn version.
Changes:
- Updated
MicrosoftCodeAnalysisVersion_LatestVSfrom 4.14.0 to 5.4.0-2.26060.102 - Added
MicrosoftCodeAnalysisVersion_5_0for VS 18.0/.NET SDK 10.0.1xx compatibility - Suppressed IDE0071 warning for a necessary
.ToString()call in TypeNameParser - Removed unnecessary
.ToString()calls in MLDsa cryptography implementations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Updates Roslyn/Code Analysis versions to align with SDK 10.0.1xx and adds new version property for VS 18.0 compatibility |
| src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeNameParser.cs | Adds pragma warning disable/restore for IDE0071 around Debug.Assert with ReadOnlySpan.ToString() |
| src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs | Removes unnecessary ToString() call on ReadOnlySpan in Debug.Fail message |
| src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.Windows.cs | Removes unnecessary ToString() call on ReadOnlySpan in Debug.Fail message |
3 tasks
This was referenced Jan 23, 2026
Member
|
This is probably superseded by #123527 |
Member
Author
|
Yup, that should unblock flow. I'll leave this open for the style fixes and #123509 (comment). |
Member
|
Not sure we should take these style changes. Seem more like suggestions than real improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #123509, this updates the MicrosoftCodeAnalysisVersion_LatestVS to match what is included in the SDK from global.json.
It adds a new property that has the 10.0 version (from #123509).