Avoid C4319 build warnings in libunwind (#122179) #123535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include libunwind/libunwind#931 in the build of the libunwind dependency. Fixes runtime build errors on `1es-windows-2022-open` that are blocking HTTP & SSL stress runs. - [x] Found internally Our internal HTTP and SSL stress tests are failing to build on the 8.0 branch. An update of MSVC in the `1es-windows-2022-open` image brought updated analyzer rules that now fail the build of dotnet/runtime on Windows. ``` mempool.c(96): warning C4319: '~': zero extending 'unsigned long' to 'size_t' of greater size ``` This change adds `(size_t)` casts in the libunwind dependency, which resolves the new errors. - [X] Yes Infra update. Regular CI is still passing + CI stress runs for HTTP and SSL now build and work again. Low. This is a one-line targeted fix that only adds casts.
ViktorHofer
requested review from
a team and
AaronRobinsonMSFT
as code owners
github-actions
bot
added
the
needs-area-label
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies an upstream libunwind fix to resolve C4319 build warnings on VS2026 related to zero-extending unsigned long to size_t in the UNW_ALIGN macro. The change is a backport to the release/9.0 branch that adds explicit size_t casts to prevent compiler warnings when building on Windows with updated MSVC analyzer rules.
Changes:
- Modified the UNW_ALIGN macro to use explicit size_t casts instead of unsigned long literals
- Updated the version tracking file to document the application of upstream PR #931
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/external/libunwind/include/libunwind_i.h | Updated UNW_ALIGN macro with explicit size_t casts to resolve C4319 warnings |
| src/native/external/libunwind-version.txt | Added documentation of upstream PR #931 being applied |
ViktorHofer
changed the title
ViktorHofer
changed the title
akoeplinger
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #122179 to fix the broken runtime build with VS 2026