SPMI: Tolerate missing getContinuationType calls #123536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The continuation type returned to the JIT by getContinuationType is more or less opaque. The only thing we need to do with that handle is embed it in the code stream. Teach SPMI to fake up a class handle instead of missing contexts when the continuation layout is not found. This is going to be a common scenario for async changes because any change resulting in new live state around an async call ends up requiring a different continuation type.
github-actions
bot
added
the
needs-area-label
jakobbotsch
added
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
Member
Author
|
PTAL @dotnet/jit-contrib I was surprised to see no diffs in #123500, but on a closer look it made perfect sense since the change causes us to require much smaller continuations, which ended up missing in |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SuperPMI replay to tolerate getContinuationType mismatches by returning a synthetic continuation type handle when the recorded continuation layout can’t be found, avoiding unnecessary “missing context” failures during async-related diffs.
Changes:
- Introduces a pseudo continuation
CORINFO_CLASS_HANDLEvalue for replay-time misses. - Adds special handling in
repEmbedClassHandlefor the pseudo handle to keep embedding behavior consistent. - Changes
repGetContinuationTypeto fall back to the pseudo handle when the recorded key is not present.
EgorBo
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuation type returned to the JIT by getContinuationType is more or less opaque. The only thing we need to do with that handle is embed it in the code stream.
Teach SPMI to fake up a class handle instead of missing contexts when the continuation layout is not found. This is going to be a common scenario for async changes because any change resulting in new live state around an async call ends up requiring a different continuation type.