Run OneLocBuild and SourceIndex on schedule instead of every commit in runtime-official.yml #123539
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
/ba-g not tested in public CI, merging |
There was a problem hiding this comment.
Pull request overview
This PR optimizes CI resource usage by restricting OneLocBuild and SourceIndex operations to scheduled and manual builds instead of running on every commit to the main branch. Since these operations only update daily anyway, there's no benefit to running them continuously as builds complete faster with assetless builds.
Changes:
- Added a daily schedule trigger that runs at 9:00 AM UTC for the main branch
- Modified the condition for the Localization and Source_Index stages to only execute on scheduled or manual builds
| schedules: | ||
| - cron: "0 9 * * *" | ||
| displayName: Daily OneLocBuild and SourceIndex | ||
| branches: | ||
| include: | ||
| - main |
There was a problem hiding this comment.
The schedule definition is missing the always: property. Based on the codebase conventions, all schedule definitions include this property to explicitly control whether the schedule runs unconditionally or only when there are changes since the last successful run.
For localization and source indexing, you likely want always: true to ensure these tasks run on schedule regardless of code changes (since localization data and source indexing may need updates even without code changes). Alternatively, if you want to conserve resources by only running when there are code changes, use always: false with a clarifying comment.
The OneLoc team reached out to me and told me that we need to run it on every build, otherwise it will cause alerts in their system. Move OneLocBuild back and only run SourceIndex daily. Follow up to #123539
2 participants
When we moved to assetless builds the time it took for runtime-official to execute got very short, which means we basically now run a build for ~every commit that gets pushed.
We don't need to do a OneLocBuild and SourceIndex all the time since those only update daily anyway, allowing us to save CI resources.