[clr-interp] Windows Arm64 InterpreterStub fix#123728
Merged
davidwrighton merged 1 commit intodotnet:mainfrom Jan 29, 2026
Merged
[clr-interp] Windows Arm64 InterpreterStub fix#123728davidwrighton merged 1 commit intodotnet:mainfrom
davidwrighton merged 1 commit intodotnet:mainfrom
Conversation
Member
davidwrighton
commented
Jan 28, 2026
davidwrighton
commented
- If the ThreadContext is not set up, make sure to set x19 to have the IR bytecode address before jumping to GetInterpThreadContextWithPossiblyMissingThreadOrCallStub.
- If the ThreadContext is not set up, make sure to set x19 to have the IR bytecode address before jumping to GetInterpThreadContextWithPossiblyMissingThreadOrCallStub.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Windows ARM64 InterpreterStub implementation where the IR bytecode address register (x19) was not being initialized before a conditional branch that could cause execution to jump to code that expects x19 to be set.
Changes:
- Reordered two assembly instructions in InterpreterStub to ensure x19 is set before the conditional branch check
davidwrighton
added
area-CodeGen-Interpreter-coreclr
and removed
area-VM-coreclr
labels
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
This was referenced Jan 29, 2026
Open
Member
Author
|
/ba-g known infra failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.