Skip to content

JIT: fix arm32 dump/disasm of references to async resume info #123814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 4 commits into from
Jan 31, 2026
+15 −8
Merged

JIT: fix arm32 dump/disasm of references to async resume info #123814

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97fb80a
Initial plan
Copilot Jan 30, 2026
3c646f2
Fix arm32 dump/disasm to handle null jdsc for async resume info
Copilot Jan 30, 2026
3874312
Improve comment to clarify when jdsc is null
Copilot Jan 30, 2026
b307df7
Use nullptr instead of NULL and print RWD format for non-block-addres…
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/coreclr/jit/emitarm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7285,7 +7285,7 @@ void emitter::emitDispInsHelp(
emitDispReg(id->idReg1(), attr, true);
imm = emitGetInsSC(id);
{
dataSection* jdsc = 0;
dataSection* jdsc = nullptr;
NATIVE_OFFSET offs = 0;

/* Find the appropriate entry in the data section list */
Expand All @@ -7305,22 +7305,29 @@ void emitter::emitDispInsHelp(
offs += size;
}

assert(jdsc != NULL);

if (id->idIsDspReloc())
{
printf("reloc ");
}
printf("%s ADDRESS J_M%03u_DS%02u", (id->idIns() == INS_movw) ? "LOW" : "HIGH", emitComp->compMethodID,
imm);

// After the MOVT, dump the table
if (id->idIns() == INS_movt)
if (jdsc != nullptr)
{
printf("%s ADDRESS J_M%03u_DS%02u", (id->idIns() == INS_movw) ? "LOW" : "HIGH",
emitComp->compMethodID, imm);
}
else
{
printf("%s ADDRESS RWD%02zu", (id->idIns() == INS_movw) ? "LOW" : "HIGH", (size_t)imm);
}

// After the MOVT, dump the table if jdsc is not null. jdsc is null for async resume info
// and non-null for block address tables.
if (jdsc != nullptr && id->idIns() == INS_movt)
{
unsigned cnt = jdsc->dsSize / TARGET_POINTER_SIZE;
BasicBlock** bbp = (BasicBlock**)jdsc->dsCont;

bool isBound = (emitCodeGetCookie(*bbp) != NULL);
bool isBound = (emitCodeGetCookie(*bbp) != nullptr);

if (isBound)
{
Expand Down
Loading