Skip to content

Remove extra array allocations from TarHeader.GetLongMetadataStream #123835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Feb 1, 2026
+3 −5
Merged

Remove extra array allocations from TarHeader.GetLongMetadataStream #123835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,9 @@ internal async Task WriteAsGnuAsync(Stream archiveStream, Memory<byte> buffer, C

private static MemoryStream GetLongMetadataStream(string text)
{
MemoryStream data = new MemoryStream();
data.Write(Encoding.UTF8.GetBytes(text));
data.WriteByte(0); // Add a null terminator at the end of the string, _size will be calculated later
data.Position = 0;
return data;
byte[] arr = new byte[Encoding.UTF8.GetByteCount(text) + 1]; // +1 for null terminator
Encoding.UTF8.GetBytes(text, arr);
return new MemoryStream(arr);
}

private TarHeader GetGnuLongLinkMetadataHeader()
Expand Down
Loading